New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the lifecycle of kube-proxy to be managed independently of the … #91977
Conversation
Hi @varunmar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign bowei |
/ok-to-test |
4e3c538
to
63e4d9c
Compare
/retest |
435d322
to
0b9dc96
Compare
/retest |
/test pull-kubernetes-integration |
PTAL again. Fixed some spacing in the bash if statement :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this looks good to me. Much easier to have a direct env that controls the behavior.
/lgtm
@bowei 👋 can you approve? |
/lgtm |
/retest |
…startup scripts for GCE Introduces a new env variable KUBE_PROXY_DISABLE which causes the configure scripts to skip over the creation of both static pods as well as daemonset addons for kube-proxy. When false, the behavior falls back to the default today, which is to rely on the value of KUBE_PROXY_DAEMONSET to decide whether to start static pods on the nodes or an addon on the master.
0b9dc96
to
04a51ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, MrHohn, varunmar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…startup scripts for GCE
Introduces a new env variable KUBE_PROXY_DISABLE which causes the configure scripts to skip over
the creation of both static pods as well as daemonset addons for kube-proxy.
When false, the behavior falls back to the default today, which is to rely on the value of
KUBE_PROXY_DAEMONSET to decide whether to start static pods on the nodes or an addon on the
master.
/kind feature
What this PR does / why we need it:
This allows the management of kube-proxy (lifetime and version) to be optionally decoupled from the
Does this PR introduce a user-facing change?:
Yes, a new environment variable is available to cluster creators.