Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sjenning as kubelet approver #92203

Merged
merged 1 commit into from Jun 20, 2020

Conversation

sjenning
Copy link
Contributor

What type of PR is this?
/kind cleanup
/priority backlog
/sig node
/assign @derekwaynecarr @dchen1107

NOTE: this is stacked on top of #86223 and it should merge first

What this PR does / why we need it:
As proposed in sig-node on 12/10/2019 by @RainbowMango and approved by @dchen1107 and @derekwaynecarr during the meeting, I am adding myself as a kubelet approver. There was agreement at sig-node that we should use this to establish a bar for use in future decisions to grant approver status.

The community membership docs say that approver requirements are "highly experienced and active reviewer + contributor to a subproject".

My experience:
Kubernetes member working on the kubelet since 2/2016
I have 93 commits in kubernetes/kubernetes with 53 commits in {pkg,cmd}/kubelet
I am an active member of SIG-Node, regularly attending and participating in the sig weekly meeting
PRs Issues
I am already a sig-node-reviewer and an approver on the following kubelet subcomponents:

  • pkg/kubelet/preemption
  • pkg/kubelet/cm
  • pkg/kubelet/images
  • pkg/kubelet/eviction
  • pkg/kubelet/metrics
  • pkg/kubelet/cadvisor

see #86223 (comment)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 16, 2020
@sjenning
Copy link
Contributor Author

/hold

Well, I didn't see how old the base is for #86223. I will wait until it merges then rebase to avoid churn.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@sjenning sjenning changed the title add sjenning as kubelet approver Add sjenning as kubelet approver Jun 16, 2020
@derekwaynecarr
Copy link
Member

Thanks for stepping up @sjenning and providing your work and input to SIG Node over the years.

I support this change, and will defer to @dchen1107 or @dashpole for final approve.

@dims
Copy link
Member

dims commented Jun 17, 2020

w00t! thanks for stepping up @sjenning

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@dims
Copy link
Member

dims commented Jun 19, 2020

/assign @saad-ali @msau42

@derekwaynecarr
Copy link
Member

/assign @dashpole

@derekwaynecarr derekwaynecarr removed their assignment Jun 19, 2020
@dchen1107
Copy link
Member

/lgtm

Support! Will leave @dashpole for the final approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@dashpole
Copy link
Contributor

/approve

@dashpole
Copy link
Contributor

Do you mean to remove yourself from pkg/volume approver?

@sjenning
Copy link
Contributor Author

gah, good catch @dashpole
/hold

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2020
@sjenning
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@dims
Copy link
Member

dims commented Jun 19, 2020

reapply lgtm :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@SergeyKanzhelev
Copy link
Member

Also it may be good to add @dashpole and you into sig-node-approvers in https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES (as commented here: #86223 (comment))

@sjenning
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 86ad0df into kubernetes:master Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 20, 2020
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2020
…03-upstream-release-1.18

Automated cherry pick of #92203: add sjenning as kubelet approver
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2020
…03-upstream-release-1.17

Automated cherry pick of #92203: add sjenning as kubelet approver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants