New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sjenning as kubelet approver #92203
Add sjenning as kubelet approver #92203
Conversation
/hold Well, I didn't see how old the base is for #86223. I will wait until it merges then rebase to avoid churn. |
Thanks for stepping up @sjenning and providing your work and input to SIG Node over the years. I support this change, and will defer to @dchen1107 or @dashpole for final approve. |
w00t! thanks for stepping up @sjenning |
415ab82
to
e0456bd
Compare
/assign @dashpole |
/lgtm Support! Will leave @dashpole for the final approval. |
/approve |
Do you mean to remove yourself from pkg/volume approver? |
gah, good catch @dashpole |
e0456bd
to
45d2b98
Compare
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
reapply lgtm :) /lgtm |
Also it may be good to add @dashpole and you into |
/retest |
…03-upstream-release-1.18 Automated cherry pick of #92203: add sjenning as kubelet approver
…03-upstream-release-1.17 Automated cherry pick of #92203: add sjenning as kubelet approver
What type of PR is this?
/kind cleanup
/priority backlog
/sig node
/assign @derekwaynecarr @dchen1107
NOTE: this is stacked on top of #86223 and it should merge first
What this PR does / why we need it:
As proposed in sig-node on 12/10/2019 by @RainbowMango and approved by @dchen1107 and @derekwaynecarr during the meeting, I am adding myself as a kubelet approver. There was agreement at sig-node that we should use this to establish a bar for use in future decisions to grant approver status.
The community membership docs say that approver requirements are "highly experienced and active reviewer + contributor to a subproject".
My experience:
Kubernetes member working on the kubelet since 2/2016
I have 93 commits in kubernetes/kubernetes with 53 commits in {pkg,cmd}/kubelet
I am an active member of SIG-Node, regularly attending and participating in the sig weekly meeting
PRs Issues
I am already a
sig-node-reviewer
and an approver on the following kubelet subcomponents:see #86223 (comment)
Does this PR introduce a user-facing change?: