Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job's backoffLimit not correct #92245

Closed
yasongxu opened this issue Jun 18, 2020 · 6 comments
Closed

Job's backoffLimit not correct #92245

yasongxu opened this issue Jun 18, 2020 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@yasongxu
Copy link
Contributor

What happened:

when I create a job like this :

apiVersion: batch/v1
kind: Job
metadata:
  name: demo
  namespace: default
spec:
  completions: 1
  backoffLimit: 6
  parallelism: 1
  template:
    metadata:
      name: demo
    spec:
      containers:
      - command:
        - sh
        - -c
        - exit 1
        image: nginx
        imagePullPolicy: IfNotPresent
        name: nginx
      restartPolicy: Never

job will eventually fail after it creates 5 failed pods, but it should be 6 failed pods.

status:
    conditions:
    - lastProbeTime: "2020-06-18T06:06:48Z"
      lastTransitionTime: "2020-06-18T06:06:48Z"
      message: Job has reached the specified backoff limit
      reason: BackoffLimitExceeded
      status: "True"
      type: Failed
    failed: 5
    startTime: "2020-06-18T06:01:55Z"
Events:
  Type     Reason                Age   From            Message
  ----     ------                ----  ----            -------
  Normal   SuccessfulCreate      39m   job-controller  Created pod: demo-ctvjt
  Normal   SuccessfulCreate      39m   job-controller  Created pod: demo-vjbvt
  Normal   SuccessfulCreate      38m   job-controller  Created pod: demo-5tls6
  Normal   SuccessfulCreate      38m   job-controller  Created pod: demo-6x5cz
  Normal   SuccessfulCreate      36m   job-controller  Created pod: demo-2d5mf
  Warning  BackoffLimitExceeded  34m   job-controller  Job has reached the specified backoff limit

Environment:
kubernetes version : 1.16.8 、 1.19.0

same issue

#70251
#64787

or any plan for this issue #64787 ?

@yasongxu yasongxu added the kind/bug Categorizes issue or PR as related to a bug. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 18, 2020
@yasongxu
Copy link
Contributor Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 18, 2020
@farah
Copy link
Contributor

farah commented Jun 21, 2020

I'll have a look at it, thanks.

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Development

No branches or pull requests

4 participants