Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore docker focal version in gci nodes #92344

Merged
merged 1 commit into from Jun 21, 2020
Merged

Restore docker focal version in gci nodes #92344

merged 1 commit into from Jun 21, 2020

Conversation

jesusha123
Copy link
Contributor

@jesusha123 jesusha123 commented Jun 20, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
This change reverts a workaround needed to install docker in ubuntu focal fossa gci nodes.

Which issue(s) this PR fixes:
Fixes #90709

Special notes for your reviewer:
The workaround was installing docker on focal fossa nodes from the bionic repo instead of the focal fossa repo because the focal fossa repo did not exist. Docker team has now created the focal fossa repo, so we no longer need the workaround.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from karan and mml June 20, 2020 15:32
@jesusha123
Copy link
Contributor Author

/sig release
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2020
@jesusha123
Copy link
Contributor Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 20, 2020 15:33
@jesusha123
Copy link
Contributor Author

/retest

@dims
Copy link
Member

dims commented Jun 20, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jherrera123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@justaugustus
Copy link
Member

/retest

@jesusha123
Copy link
Contributor Author

Taking a quick look at the focal repo packages, it is missing s390x and maybe armhf and ppc64el architectures. However, the modified script is for gce, which according to the doc, only supports Intel and AMD CPUs (x86-64), so it shouldn't affect the test negatively.

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-verify

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind

2 similar comments
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind

@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@justaugustus
Copy link
Member

/test pull-kubernetes-verify

@justaugustus
Copy link
Member

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jesusha123
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d140769 into kubernetes:master Jun 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karan karan Awaiting requested review from karan

@mml mml Awaiting requested review from mml

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Docker repository does not yet support focal fossa
5 participants
@jesusha123 @dims @k8s-ci-robot @justaugustus @fejta-bot