Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InstanceMetadataByProviderID for unmanaged nodes #92572

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix InstanceMetadataByProviderID for unmanaged nodes #92572

merged 1 commit into from
Jun 30, 2020

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Jun 28, 2020 •
edited

What type of PR is this?

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure

What this PR does / why we need it:

Fix InstanceMetadataByProviderID for unmanaged nodes: check whether a node is managed or not before invoking Azure APIs.

It also changes the IMDS cache type back of CacheReadTypeDefault, so that new IPs from IMDS could get dynamically.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix InstanceMetadataByProviderID for unmanaged nodes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider area/cloudprovider labels Jun 28, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2020
@feiskyer
Copy link
Member Author

/retest

2 similar comments
@feiskyer
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member

/retest

@feiskyer feiskyer added this to In progress in Provider Azure via automation Jun 29, 2020
@nilo19
Copy link
Member

nilo19 commented Jun 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andyzhangx
andyzhangx approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 4670138 into kubernetes:master Jun 30, 2020
Provider Azure automation moved this from In progress to Done Jun 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 30, 2020
@feiskyer feiskyer deleted the fix-instance-metadata branch June 30, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@andyzhangx andyzhangx

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@feiskyer @andyzhangx @nilo19 @k8s-ci-robot