Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pod /etc/hosts in ephemeral storage calculation for eviction #92916

Merged
merged 1 commit into from Jul 12, 2020
Merged

Include pod /etc/hosts in ephemeral storage calculation for eviction #92916

merged 1 commit into from Jul 12, 2020

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Jul 8, 2020 •
edited by saschagrunert

What type of PR is this?
/kind bug

What this PR does / why we need it:
Includes a pod /etc/hosts when calculating a pod's ephemeral storage usage to decide whether to evict the pod.

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:

CVE-2020-8557 (Medium): Node-local denial of service via container /etc/hosts file. See https://github.com/kubernetes/kubernetes/issues/93032 for more details.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 8, 2020
@rphillips
Copy link
Member

/lgtm
/assign @derekwaynecarr
/cc @sjenning

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2020
@sjenning
Copy link
Contributor

sjenning commented Jul 8, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@rphillips
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@joelsmith
Copy link
Contributor Author

/retest

This was referenced Jul 8, 2020
Merged
Merged
@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelsmith joelsmith mentioned this pull request Jul 8, 2020
Merged
@spiffxp spiffxp added this to the v1.19 milestone Jul 9, 2020
@tallclair tallclair added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8398bc3 into kubernetes:master Jul 12, 2020
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2020
@k8s-ci-robot
Merge pull request #92924 from joelsmith/automated-cherry-pick-of-#92…
14eea29 
…916-upstream-release-1.16

Automated cherry pick of #92916: Include pod /etc/hosts in ephemeral storage calculation for
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2020
@k8s-ci-robot
Merge pull request #92921 from joelsmith/automated-cherry-pick-of-#92…
ef95138 
…916-upstream-release-1.18

Automated cherry pick of #92916: Include pod /etc/hosts in ephemeral storage calculation for
k8s-ci-robot added a commit that referenced this pull request Jul 13, 2020
@k8s-ci-robot
Merge pull request #92923 from joelsmith/automated-cherry-pick-of-#92…
d1c2f63 
…916-upstream-release-1.17

Automated cherry pick of #92916: Include pod /etc/hosts in ephemeral storage calculation for
@joelsmith joelsmith mentioned this pull request Jul 15, 2020
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 15, 2020
@joelsmith joelsmith mentioned this pull request Dec 3, 2020
Merged
@pacoxu pacoxu mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@rphillips rphillips

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joelsmith @rphillips @sjenning @derekwaynecarr @k8s-ci-robot @spiffxp @tallclair