Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saschagrunert and alejandrox1 to sig-release-approvers #92961

Merged
merged 1 commit into from Jul 12, 2020
Merged

Add saschagrunert and alejandrox1 to sig-release-approvers #92961

merged 1 commit into from Jul 12, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 10, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
To fulfill the role as new technical lead we
need to be part of the SIG
release approvers role.

Which issue(s) this PR fixes:
Ref kubernetes/community#4867
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 10, 2020
@saschagrunert saschagrunert mentioned this pull request Jul 10, 2020
Merged
@saschagrunert
Copy link
Member Author

/assign @kubernetes/sig-release-admins
/cc @kubernetes/sig-release

@saschagrunert
Add saschagrunert and alejandrox1 to sig-release-approvers
0fd9d34 
To fulfill the role as new technical lead we need to be part of the SIG
release approvers role.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title Add saschagrunert to sig-release-approvers Add saschagrunert and alejandrox1 to sig-release-approvers Jul 10, 2020
@saschagrunert
Copy link
Member Author

I'll stop spamming retest until the situation with tide got a bit better.

hasheddan
hasheddan approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@justaugustus
Copy link
Member

/lgtm
/approve
/assign @liggitt @thockin
/retest
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 10, 2020
@justaugustus justaugustus added this to In progress in SIG Release via automation Jul 10, 2020
@liggitt
Copy link
Member

liggitt commented Jul 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@saschagrunert
Copy link
Member Author

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: The label(s) sig/ cannot be applied, because the repository doesn't have them

In response to this:

/sig release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 99d85ef into kubernetes:master Jul 12, 2020
SIG Release automation moved this from In progress to Done (1.19) Jul 12, 2020
@saschagrunert saschagrunert deleted the owners-aliases branch July 12, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@justaugustus justaugustus

@liggitt liggitt

@thockin thockin

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @justaugustus @liggitt @k8s-ci-robot @hasheddan @thockin