Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-release: Add Jorge Alarcon Ochoa and Sascha Grunert as TLs #4867

Merged
merged 1 commit into from
Jun 18, 2020
Merged

sig-release: Add Jorge Alarcon Ochoa and Sascha Grunert as TLs #4867

merged 1 commit into from
Jun 18, 2020

Conversation

justaugustus
Copy link
Member

Discussed on the SIG Release mailing list and in today's SIG Release meeting.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @tpepper @calebamiles @alejandrox1 @saschagrunert
cc: @kubernetes/sig-release
/hold for lazy consensus (timeout: Thursday, June 18 at 4pm US Eastern)

@justaugustus
sig-release: Add Jorge Alarcon Ochoa and Sascha Grunert as TLs
c5cfd88 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 16, 2020
markjacksonfishing
markjacksonfishing approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000000000
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2020
@jeremyrickard
Copy link
Contributor

+1
+1

saschagrunert
saschagrunert approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a pleasure, thank you! 😊 Jorge and myself will start working on a more detailed description and playbook as discussed today. We’ll propose that as a PR in the next week.

/lgtm

hasheddan
hasheddan approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jimangel
Copy link
Member

/lgtm ♥️

@tpepper
Copy link
Member

tpepper commented Jun 16, 2020

/lgtm
/approve

@onlydole
Copy link
Member

/lgtm

+100000

@cblecker
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
cpanato
cpanato approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100000
/lgtm

@jdumars
Copy link
Member

jdumars commented Jun 18, 2020

/lgtm
/approve
leftshark

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cpanato, hasheddan, jdumars, justaugustus, markyjackson-taulia, saschagrunert, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Lazy consensus timeout has been achieved!

So now, officially, welcome @saschagrunert and @alejandrox1 to the leadership team!
I'm extremely excited to have you two working more closely with us. :)

/honk
/pony party
/meow glasses
/woof
/hold cancel

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
goose image

In response to this:

Lazy consensus timeout has been achieved!

So now, officially, welcome @saschagrunert and @alejandrox1 to the leadership team!
I'm extremely excited to have you two working more closely with us. :)

/honk
/pony party
/meow glasses
/woof
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@justaugustus: dog image

In response to this:

Lazy consensus timeout has been achieved!

So now, officially, welcome @saschagrunert and @alejandrox1 to the leadership team!
I'm extremely excited to have you two working more closely with us. :)

/honk
/pony party
/meow glasses
/woof
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@justaugustus: cat image

In response to this:

Lazy consensus timeout has been achieved!

So now, officially, welcome @saschagrunert and @alejandrox1 to the leadership team!
I'm extremely excited to have you two working more closely with us. :)

/honk
/pony party
/meow glasses
/woof
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@justaugustus: pony image

In response to this:

Lazy consensus timeout has been achieved!

So now, officially, welcome @saschagrunert and @alejandrox1 to the leadership team!
I'm extremely excited to have you two working more closely with us. :)

/honk
/pony party
/meow glasses
/woof
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit fd5df0d into kubernetes:master Jun 18, 2020
@saschagrunert
Copy link
Member

Wow, thank you so much all! 🤭🤗

This was referenced Jul 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@hasheddan hasheddan hasheddan approved these changes

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@onlydole onlydole

@saschagrunert saschagrunert

@calebamiles calebamiles

@jdumars jdumars

@tpepper tpepper

@cpanato cpanato

@alejandrox1 alejandrox1

@markjacksonfishing markjacksonfishing

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet