Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subjectAltName to test serving certificates #93426

Merged
merged 1 commit into from Jul 24, 2020
Merged

Add subjectAltName to test serving certificates #93426

merged 1 commit into from Jul 24, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 24, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes the test certificates used to include the hostname as a subjectAltName

go1.15 starts enforcing this, but the RFC requires this to be the case already, so go ahead and fix the issue.

Does this PR introduce a user-facing change?:

NONE

/cc @justaugustus

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2020
@justaugustus justaugustus mentioned this pull request Jul 24, 2020
Merged
6 tasks
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 24, 2020
@liggitt liggitt added this to the v1.19 milestone Jul 24, 2020
@justaugustus
Copy link
Member

/lgtm
/approve
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

Pod pending timeout.

/retest

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind acce887 link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce-ubuntu-containerd acce887 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce acce887 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6f7b6b6 into kubernetes:master Jul 24, 2020
@liggitt liggitt deleted the test-certs branch July 27, 2020 13:55
@fedebongio
Copy link
Contributor

/remove-triage needs-information

@k8s-ci-robot k8s-ci-robot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @justaugustus @k8s-ci-robot @fedebongio