-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang to v1.15.0-rc.1 #93264
Conversation
9634e87
to
9c54da4
Compare
/test pull-kubernetes-verify |
Please don't use the release branches of the golang.org subrepos. They are not what you might think they are: we make release branches to track the version that is vendored into a Go release, not the version that is compatible with a Go release. These release branches are not documented and not supported, and if there is a security vulnerability in a package that is not vendored into the standard library, they will not get the update. You should treat golang.org modules like any other module. |
Thanks @FiloSottile! So you're saying we'd be better suited targeting the |
Yes, if that's your policy for other dependencies. If you are using Go modules, the standard thing to track would be |
hack/pin-dependency.sh golang.org/x/crypto release-branch.go1.15 hack/pin-dependency.sh golang.org/x/mod release-branch.go1.15 hack/pin-dependency.sh golang.org/x/net release-branch.go1.15 hack/pin-dependency.sh golang.org/x/text v0.3.3 hack/pin-dependency.sh golang.org/x/tools release-branch.go1.15 hack/pin-dependency.sh golang.org/x/xerrors release-branch.go1.15 Did not pin golang.org/x/sys to release-branch.go1.15 because we require a newer level
/lgtm added followups to the description |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @liggitt! Full tracking issue is here and I'll get the follow-ups added to it: kubernetes/release#1421 |
which isn't normally a flaky test /retest |
@FiloSottile thanks for the guidance! |
What type of PR is this?
/kind cleanup
/area dependency release-eng
/sig release
What this PR does / why we need it:
Update Golang to v1.15.0
Depends on fixes in earlier PRs (which must also be included if go1.15 support is backported):
Followups (which must also be done in earlier releases if go1.15 support is backported):
minimum_go_version=go1.15
inhack/lib/golang.sh
Signed-off-by: Stephen Augustus saugustus@vmware.com
cc: @kubernetes/release-engineering @kubernetes/release-team-leads @kubernetes/sig-scalability-feature-requests @liggitt @dims
Tracking issue: kubernetes/release#1421
Special notes for your reviewer:
This is testing against a pre-release version of go1.15 (
go1.15rc1
).Expect a slew of errors, as various parts of our code are not configured to accept Go pre-release versions.Also, there will definitely be bazel toolchain + rules_go errors.Does this PR introduce a user-facing change?: