Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #88251: fix incorrect configuration of kubepods.slice unit by kubelet #93863

Merged
merged 1 commit into from Aug 31, 2020
Merged

Automated cherry pick of #88251: fix incorrect configuration of kubepods.slice unit by kubelet #93863

merged 1 commit into from Aug 31, 2020

Conversation

reegnz
Copy link

@reegnz reegnz commented Aug 10, 2020

Cherry pick of #88251 on release-1.16.

#88251: fix incorrect configuration of kubepods.slice unit by kubelet

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @reegnz!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

@odinuge do you think this will make it to the aug 12th deadline? Since that will be the last 1.16 release I would be really glad to have this fix included.

@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

/assign @dchen1107

@odinuge
Copy link
Member

odinuge commented Aug 10, 2020

Well, lets see how fast we can get it approved... All cherry-picks needs a changelog entry, so you have to add one to the PR.

/lgtm
/kind bug
/assign @sjenning

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

@odinuge seems like the original PR didn't have a release note. I set release notes to none for now.

@reegnz reegnz mentioned this pull request Aug 10, 2020
Merged
odinuge
odinuge reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, reegnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@SergeyKanzhelev
Copy link
Member

/retest

@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-integration

@reegnz
Copy link
Author

reegnz commented Aug 11, 2020

Anything else I need to do to get this merged for tomorrow's deadline?

@odinuge
Copy link
Member

odinuge commented Aug 11, 2020

Ping @kubernetes/release-managers

@reegnz
Copy link
Author

reegnz commented Aug 13, 2020

Okay, I'm guessing this won't make it into the release?

Sorry, didn't have much time to babysit this PR. :(

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit adb5fcb into kubernetes:release-1.16 Aug 31, 2020
@reegnz reegnz deleted the automated-cherry-pick-of-#88251-upstream-release-1.16 branch August 31, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge odinuge left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@vishh vishh Awaiting requested review from vishh

Assignees

@sjenning sjenning

@odinuge odinuge

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@reegnz @k8s-ci-robot @odinuge @derekwaynecarr @SergeyKanzhelev @sjenning @justaugustus @dchen1107 @olegch