Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #88251: fix incorrect configuration of kubepods.slice unit by kubelet #93864

Merged
merged 1 commit into from Sep 3, 2020
Merged

Automated cherry pick of #88251: fix incorrect configuration of kubepods.slice unit by kubelet #93864

merged 1 commit into from Sep 3, 2020

Conversation

reegnz
Copy link

@reegnz reegnz commented Aug 10, 2020

Cherry pick of #88251 on release-1.17.

#88251: fix incorrect configuration of kubepods.slice unit by kubelet

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

/assign @yujuhong

@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

@odinuge related to #93863, this one is for 1.17.

@odinuge
Copy link
Member

odinuge commented Aug 10, 2020

/lgtm
/kind bug
/assign @sjenning

Pretty sure sig-release enforce changelogs on all cherry-picks, but I guess you can try without and see.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@reegnz
Copy link
Author

reegnz commented Aug 10, 2020

/test pull-kubernetes-node-e2e

@k8s-ci-robot
Copy link
Contributor

@reegnz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-node-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

odinuge
odinuge reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, reegnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@SergeyKanzhelev
Copy link
Member

timeouts...

/retest

@reegnz
Copy link
Author

reegnz commented Aug 12, 2020 •
edited

Ping @kubernetes/release-managers

EDIT: I cannot seem to be able to ping this group.

@SergeyKanzhelev
Copy link
Member

CC @kubernetes/release-managers

@SergeyKanzhelev
Copy link
Member

Ping @kubernetes/release-managers

EDIT: I cannot seem to be able to ping this group.

I'm not sure why. Pinged them for you

@odinuge
Copy link
Member

odinuge commented Aug 15, 2020

EDIT: I cannot seem to be able to ping this group.

You have to be member of the kubernetes github org. in order to search for and tag groups.

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 3, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 3, 2020
@cpanato
Copy link
Member

cpanato commented Sep 3, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6ad9af2 into kubernetes:release-1.17 Sep 3, 2020
@reegnz
Copy link
Author

reegnz commented Sep 3, 2020

Thanks! 🎉

@reegnz reegnz deleted the automated-cherry-pick-of-#88251-upstream-release-1.17 branch September 3, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge odinuge left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@vishh vishh Awaiting requested review from vishh

Assignees

@sjenning sjenning

@odinuge odinuge

@derekwaynecarr derekwaynecarr

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@reegnz @k8s-ci-robot @odinuge @derekwaynecarr @SergeyKanzhelev @cpanato @sjenning @yujuhong @olegch