Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add network rule support in Azure account creation #94239

Merged
merged 1 commit into from Sep 15, 2020
Merged

add network rule support in Azure account creation #94239

merged 1 commit into from Sep 15, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 26, 2020 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
add network rule support in Azure account creation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add network rule support in Azure account creation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

/priority important-soon
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Aug 26, 2020
@k8s-ci-robot k8s-ci-robot added area/cloudprovider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2020
This was referenced Aug 26, 2020
Closed
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2020
@andyzhangx
Copy link
Member Author

@Sakuralbj

#precheck before submit code
hack/verify-golint.sh
hack/verify-gofmt.sh

@Sakuralbj
Copy link
Contributor

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2020
@andyzhangx andyzhangx changed the title [WIP]chore: add network rule support in Azure account creation add network rule support in Azure account creation Sep 12, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2020
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

feiskyer
feiskyer reviewed Sep 14, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure_storageaccount.go
Action: storage.Allow,
}
virtualNetworkRules = append(virtualNetworkRules, vnetRule)
klog.V(4).Infof("subnetID(%s) has been set", subnetID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: subnetID(%s) has been set for storageAccount %s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's for creating new storage account, there is no storage account name at that time.

@andyzhangx
Copy link
Member Author

/retest

@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 15, 2020
@feiskyer feiskyer added this to In progress in Provider Azure via automation Sep 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 37cf1d6 into kubernetes:master Sep 15, 2020
Provider Azure automation moved this from In progress to Done Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@karataliu karataliu Awaiting requested review from karataliu

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @Sakuralbj @feiskyer @k8s-ci-robot