Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Plane is a better name #94407

Merged
merged 6 commits into from Sep 2, 2020
Merged

Conversation

lavalamp
Copy link
Member

@lavalamp lavalamp commented Sep 1, 2020

What type of PR is this?

/kind cleanup

Methodology:

 9200  [2020-09-01 16:03:51 -0700] mkdir pkg/cluster
 9201  [2020-09-01 16:03:59 -0700] git mv pkg/master/ports pkg/cluster/
 9202  [2020-09-01 16:04:38 -0700] grep -RIl "pkg/master/ports" . | xargs -n1 sed -i 's|pkg/master/ports|pkg/cluster/ports|g'
 9203  [2020-09-01 16:04:52 -0700] hack/update-bazel.sh 
 9204  [2020-09-01 16:06:49 -0700] git st
 9205  [2020-09-01 16:06:52 -0700] git add .
 9206  [2020-09-01 16:07:09 -0700] git commit -m "move port definitions to a common location"
 9207  [2020-09-01 16:07:31 -0700] git mv pkg/master pkg/controlplane
 9208  [2020-09-01 16:08:15 -0700] grep -RIl "master" pkg/controlplane | xargs -n1 sed -i 's|package master|package controlplane|g'
 9209  [2020-09-01 16:08:30 -0700] grep -RIl "pkg/master" . | xargs -n 1 sed -i 's|pkg/master|pkg/controlplane|g'
 9210  [2020-09-01 16:08:50 -0700] grep -RIl 'k8s.io/kubernetes/pkg/controlplane[^/]' | grep "[.]go" | xargs -n1 go run ../toplevelnamechange.go master controlplane
 9211  [2020-09-01 16:09:03 -0700] hack/update-bazel.sh
 9212  [2020-09-01 16:09:47 -0700] git add .
 9213  [2020-09-01 16:09:50 -0700] git st
 9214  [2020-09-01 16:09:58 -0700] git commit -m "rename"

I wrote a short script to do the name change without false positives: https://gist.github.com/lavalamp/f9641969bfc5f327f6a89a70b2f4668a

NONE

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2020
@lavalamp lavalamp marked this pull request as draft September 1, 2020 23:22
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/apiserver area/cloudprovider area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 1, 2020
@lavalamp lavalamp force-pushed the big-rename branch 2 times, most recently from 46b289a to 7cbc88e Compare September 1, 2020 23:45
@lavalamp
Copy link
Member Author

lavalamp commented Sep 1, 2020

(This only changes the directory structure, which can't really be done in a smaller increment.)

@lavalamp lavalamp marked this pull request as ready for review September 1, 2020 23:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2020
@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2020

/lgtm

but you've got a way to go to please the bots.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@lavalamp
Copy link
Member Author

lavalamp commented Sep 2, 2020

/test pull-kubernetes-conformance-kind-ga-only-parallel

@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
```
grep -RIl pkg/master . | xargs -n 1 sed -i 's|pkg/master|pkg/controlplane|g'
LC_ALL=C sort -o hack/.golint_failures hack/.golint_failures
```
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 2, 2020

@lavalamp: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6-parallel 9eb664f link /test pull-kubernetes-conformance-kind-ipv6-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lavalamp
Copy link
Member Author

lavalamp commented Sep 2, 2020

/test pull-kubernetes-integration

@lavalamp
Copy link
Member Author

lavalamp commented Sep 2, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 2, 2020
@oomichi
Copy link
Member

oomichi commented Sep 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@oomichi
Copy link
Member

oomichi commented Sep 2, 2020

/test pull-kubernetes-conformance-kind-ipv6-parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants