New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control Plane is a better name #94407
Conversation
46b289a
to
7cbc88e
Compare
(This only changes the directory structure, which can't really be done in a smaller increment.) |
/lgtm but you've got a way to go to please the bots. |
/retest Review the full test history for this PR. Silence the bot with an |
/test pull-kubernetes-conformance-kind-ga-only-parallel |
/lgtm |
``` grep -RIl pkg/master . | xargs -n 1 sed -i 's|pkg/master|pkg/controlplane|g' LC_ALL=C sort -o hack/.golint_failures hack/.golint_failures ```
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lavalamp: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-integration |
/milestone v1.20 |
/lgtm |
/test pull-kubernetes-conformance-kind-ipv6-parallel |
What type of PR is this?
/kind cleanup
Methodology:
I wrote a short script to do the name change without false positives: https://gist.github.com/lavalamp/f9641969bfc5f327f6a89a70b2f4668a
/sig api-machinery