Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove DefaultIngressClass feature gate for 1.20 #94510

Merged
merged 1 commit into from Sep 15, 2020
Merged

remove DefaultIngressClass feature gate for 1.20 #94510

merged 1 commit into from Sep 15, 2020

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 4, 2020 •
edited

What type of PR is this?
/kind cleanup
/sig network

What this PR does / why we need it:
According to #91957, it need to be removed in 1.20.
And the feature gate is always true in 1.19. No other changes are needed.

Which issue(s) this PR fixes:

Fixes #94500

NONE

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:
no

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@pacoxu
remove DefaultIngressClass feature gate for 1.20
291b36e 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 4, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Sep 9, 2020

/reassign

@pacoxu
Copy link
Member Author

pacoxu commented Sep 10, 2020

/sig network

@kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2020
@dims
Copy link
Member

dims commented Sep 10, 2020

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Sep 10, 2020

/unassign
/assign @thockin

routing to network feature approver

@k8s-ci-robot k8s-ci-robot assigned thockin and unassigned liggitt Sep 10, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Sep 14, 2020

@sig-network-approvers
also milestone 1.20 is needed

@dims
Copy link
Member

dims commented Sep 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Sep 14, 2020

can someone add it to the milestone ？
@kubernetes/milestone-maintainers thanks

@bai
Copy link

bai commented Sep 14, 2020

/milestone v1.20.0

@k8s-ci-robot
Copy link
Contributor

@bai: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v1.20.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bai
Copy link

bai commented Sep 14, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
cmluciano
cmluciano reviewed Sep 15, 2020
View reviewed changes
Copy link

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @robscott

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@pacoxu
Copy link
Member Author

pacoxu commented Sep 15, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 33c58af into kubernetes:master Sep 15, 2020
@pacoxu pacoxu deleted the fix/94500 branch June 23, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

@dims dims Awaiting requested review from dims

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@cmluciano cmluciano

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Feature gate DefaultIngressClass is GA - when does it get removed?
7 participants
@pacoxu @dims @liggitt @k8s-ci-robot @bai @cmluciano @thockin