-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingress: Update IngressClass feature and admission controller for v1 #91957
ingress: Update IngressClass feature and admission controller for v1 #91957
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
We prefer SIG Network to take a first look please |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this! Not sure if it belongs in this PR or not, but there's also a corresponding e2e test that should be updated.
e025870
to
5414b07
Compare
I fixed the annotation. I have the v1beta1 CRUD tests updated in #91830 and I will stage the v1 test today. |
5414b07
to
962572b
Compare
#89778 is in the merge queue. Once it merges, can rebase this and cancel hold |
Ready for rebase and hold cancel |
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
4c67011
to
92506a9
Compare
/lgtm |
/unhold |
/retest |
/hold Temporary hold to get prow/tide to get back on its feet. Feel free to remove hold in a few hours. |
/hold cancel |
/hold Temporary hold to get prow/tide to get back on its feet. Feel free to remove hold in a few hours. |
/test all |
/hold cancel |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cmluciano, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This PR updates IngressClass`s kube-feature and admission controller for v1.
Which issue(s) this PR fixes:
xref:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Ingress KEP
kubernetes/enhancements#1453