Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Update IngressClass feature and admission controller for v1 #91957

Merged
merged 1 commit into from
Jun 19, 2020
Merged

ingress: Update IngressClass feature and admission controller for v1 #91957

merged 1 commit into from
Jun 19, 2020

Conversation

cmluciano
Copy link

@cmluciano cmluciano commented Jun 9, 2020 •
edited by liggitt
Loading

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR updates IngressClass`s kube-feature and admission controller for v1.
Which issue(s) this PR fixes:
xref:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The `DefaultIngressClass` feature is now GA. The `--feature-gate` parameter will be removed in 1.20.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

kubernetes/enhancements#1453

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2020
@cmluciano
Copy link
Author

/cc @liggitt @robscott

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt mentioned this pull request Jun 9, 2020
Merged
2 tasks
@fedebongio
Copy link
Contributor

We prefer SIG Network to take a first look please

@cmluciano
Copy link
Author

/retest

@liggitt
Copy link
Member

liggitt commented Jun 9, 2020

/lgtm
/hold for the remaining v1 PRs

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2020
robscott
robscott reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Not sure if it belongs in this PR or not, but there's also a corresponding e2e test that should be updated.

staging/src/k8s.io/api/networking/v1/well_known_annotations.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@cmluciano
Copy link
Author

I fixed the annotation. I have the v1beta1 CRUD tests updated in #91830 and I will stage the v1 test today.

@liggitt
Copy link
Member

liggitt commented Jun 16, 2020

#89778 is in the merge queue.

Once it merges, can rebase this and cancel hold

@liggitt
Copy link
Member

liggitt commented Jun 17, 2020

Ready for rebase and hold cancel

ingress: Update IngressClass feature and admission controller for v1
92506a9 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 17, 2020
@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@cmluciano
Copy link
Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@cmluciano
Copy link
Author

/retest

@dims
Copy link
Member

dims commented Jun 17, 2020

/hold Temporary hold to get prow/tide to get back on its feet. Feel free to remove hold in a few hours.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@dims
Copy link
Member

dims commented Jun 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@dims
Copy link
Member

dims commented Jun 18, 2020

/hold Temporary hold to get prow/tide to get back on its feet. Feel free to remove hold in a few hours.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@dims
Copy link
Member

dims commented Jun 18, 2020

/test all

@dims
Copy link
Member

dims commented Jun 18, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@dims
Copy link
Member

dims commented Jun 18, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jun 18, 2020

/lgtm
/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot merged commit 65544c9 into kubernetes:master Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 19, 2020
This was referenced Sep 4, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@liggitt liggitt liggitt left review comments

@justinsb justinsb Awaiting requested review from justinsb

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@robscott robscott

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@cmluciano @fejta-bot @fedebongio @liggitt @robscott @dims @k8s-ci-robot