Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change code to use staging/k8s.io/mount-utils #94527

Merged
merged 1 commit into from Sep 22, 2020
Merged

Change code to use staging/k8s.io/mount-utils #94527

merged 1 commit into from Sep 22, 2020

Conversation

brahmaroutu
Copy link
Contributor

/kind cleanup
/release-note-none
sig/storage
sig/testing

What this PR does / why we need it:
This PR is moving the vendor/utils/mount package into k/k to better manage and test the source code with Storage e2e.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 4, 2020
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/kubelet area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2020
@brahmaroutu
Copy link
Contributor Author

/assign @msau42
Please review, I hope the right direction it to eliminate utils/mount from the code base. Also advisor is using utils/mount. I may have to actually change that repo or changing here would suffice?

@brahmaroutu brahmaroutu force-pushed the mount-utils-2 branch 2 times, most recently from facadbd to fe1ed8c Compare September 5, 2020 22:03
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Sep 5, 2020
@brahmaroutu
Copy link
Contributor Author

TODO : We still need to remove utils/mounts from vendor. legacy-cloud-providers/openstack and google/cadvisor/fs still depend on this package.

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-azure-file
/test pull-kubernetes-e2e-azure-file-windows

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-azure-file

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-azure-file-windows

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2020
@msau42
Copy link
Member

msau42 commented Sep 10, 2020 •
edited

There were some more commits to k8s.io/utils/mount after your initial merge. Can you copy those commits over too?

cc @andyzhangx @jingxu97 for awareness.

@brahmaroutu
Copy link
Contributor Author

brahmaroutu commented Sep 12, 2020 •
edited

@brahmaroutu can you also import the latest commits from k8s.io/utils/mount?

https://github.com/kubernetes/utils/commits/master/mount

@msau42 all commits are moved, the last one picked up is "fix: return error with fewer mount options on Windows" from 8/15.

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-windows-gce

2 similar comments
@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-windows-gce

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-windows-gce

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020
@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot

@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

@brahmaroutu
Copy link
Contributor Author

@msau42 @andyzhangx @divyenpatel Can you please review ASAP.

@jingxu97
Copy link
Contributor

/test pull-kubernetes-e2e-windows-gce

@jingxu97
Copy link
Contributor

windows test always timeout as always..

@msau42
Copy link
Member

msau42 commented Sep 18, 2020

/retest
/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
thockin
thockin reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brahmaroutu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@brahmaroutu
Copy link
Contributor Author

/milestone v1.20

@k8s-ci-robot
Copy link
Contributor

@brahmaroutu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brahmaroutu
Copy link
Contributor Author

@msau42 This PR may need milestone set for it to be merged?

@msau42
Copy link
Member

msau42 commented Sep 21, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 21, 2020
@brahmaroutu
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2020
@brahmaroutu
Copy link
Contributor Author

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit dd466bc into kubernetes:master Sep 22, 2020
@brahmaroutu brahmaroutu mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@cofyc cofyc Awaiting requested review from cofyc

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

Assignees

@thockin thockin

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brahmaroutu @msau42 @jingxu97 @andyzhangx @k8s-ci-robot @thockin