Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up remaining ns flag #94789

Merged
merged 1 commit into from Sep 17, 2020
Merged

Clean up remaining ns flag #94789

merged 1 commit into from Sep 17, 2020

Conversation

zhouya0
Copy link
Contributor

@zhouya0 zhouya0 commented Sep 15, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR is based on #94609.
And clean up two remaining places :)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/assign @soltysh
/assign @oomichi

Does this PR introduce a user-facing change?:

None

/priority backlog

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 15, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 15, 2020
@oomichi
Copy link
Member

oomichi commented Sep 15, 2020

nice catch.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@neolit123 neolit123 mentioned this pull request Sep 15, 2020
Closed
@dims
Copy link
Member

dims commented Sep 17, 2020

/approve
/lgtm
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 17, 2020
@dims
Copy link
Member

dims commented Sep 17, 2020

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Sep 17, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 660e1e4 into kubernetes:master Sep 17, 2020
@julianvmodesto julianvmodesto mentioned this pull request Nov 10, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2020
@k8s-ci-robot
Merge pull request #96434 from julianvmodesto/automated-cherry-pick-o…
528ba03 
…f-#94609-#94789-#95594-#95831-origin-release-1.19

Automated cherry pick of #94609: Use namespace flag passed to RunKubectl* methods #94789: Clean up remaining ns flag #95594: Fix --dry-run invocation in kubectl e2e #95831: use patch instead of replace to test the dry-run option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@soltysh soltysh

@liggitt liggitt

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zhouya0 @oomichi @dims @liggitt @k8s-ci-robot @soltysh