New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kubectl alpha debug default image imagePullPolicy set by the image tag #94896
Conversation
@verb
kubernetes/pkg/apis/core/v1/defaults.go Lines 79 to 90 in 7ceac2b
|
/assign @verb |
62d653d
to
94b532c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
/lgtm
/retest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-kubernetes-bazel-test |
/lgtm |
/lgtm |
/assign @sjenning @derekwaynecarr |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, wawa0210 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
The default imagePullPolicy of kubectl alpha debug is PullIfNotPresent rather than set according to whether the image tag is
:latest
.This will cause the latest image to be executed without pull, if there is already a
:latest
image locallyWhich issue(s) this PR fixes:
Fixes #92383
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: