-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.18] Remove canonicalization of endpoints by endpoints controller for better comparison #94934
[release-1.18] Remove canonicalization of endpoints by endpoints controller for better comparison #94934
Conversation
the endpoints API handler was using the Canonicalize() method to reorder the endpoints, however, due to differences with the endpoint controller RepackSubsets(), the controller was considering the endpoints different despite they were not, generating unnecessary updates evert resync period.
/lgtm @kubernetes/release-managers - for cherrypick approval |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
from parent PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1.18 backport of #94112