Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mattjmcnaughton as a sig-node reviewer #94953

Conversation

mattjmcnaughton
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
PR to remove myself as a sig-node reviewer. I unfortunately don't have
the free time to stay on top of all the different diffs coming in these
days, and I don't want the diffs I'm assigned to be blocked by a slow response from me.

I'm still hopeful I'll be able to chip in as I have time, and if I'm
able to contribute regularly again, I'll create a diff to add myself
back as a reviewer :)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Huge thanks to @dims and @derekwaynecarr for all their mentoring :) Very grateful to you two :)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


PR to remove myself as a sig-node reviewer. I unfortunately don't have
the free time to stay on top of all the different diffs coming in these
days, and I don't want diffs to be blocked by a slow response from me.

I'm still hopeful I'll be able to chip in as I have time, and if I'm
able to contribute regularly again, I'll create a diff to add myself
back as a reviewer :)
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2020
@mattjmcnaughton
Copy link
Contributor Author

/assign @dchen1107

@odinuge
Copy link
Member

odinuge commented Sep 22, 2020

Thanks for all your work, reviews and help in the community in general! It has and will still be really appreciated. 😄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020
@LappleApple
Copy link

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2020
@dchen1107
Copy link
Member

/lgtm
/approve

Matt, thank you very much for all your contribution to K8s, especially SIG Node community.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mattjmcnaughton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 82b38ce into kubernetes:master Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants