Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use host IP instead of localhost for GKE control plane kubeconfig #95209

Merged
merged 1 commit into from Oct 23, 2020
Merged

Use host IP instead of localhost for GKE control plane kubeconfig #95209

merged 1 commit into from Oct 23, 2020

Conversation

benhxy
Copy link
Contributor

@benhxy benhxy commented Sep 30, 2020 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR modifies kubeconfig file generation for GKE control plane components. Instead of using localhost:443 to target kube-apiserver, this change will use host IP. This is a part of work to allow GKE control plane components to be moved off hostNetwork, which will improve control plane security by isolating container network namespaces.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @benhxy!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @benhxy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2020
@vinayakankugoyal
Copy link
Contributor

I believe you need to specify None is release notes to remove do-not-merge/release-note-label-needed

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 2, 2020
@vinayakankugoyal
Copy link
Contributor

Why is this considered kind/cleanup?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2020
@benhxy benhxy requested a review from roycaihw October 8, 2020 03:09
@roycaihw
Copy link
Member

roycaihw commented Oct 8, 2020

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2020
@benhxy
Copy link
Contributor Author

benhxy commented Oct 8, 2020

/retest

@benhxy
Copy link
Contributor Author

benhxy commented Oct 8, 2020

/assign @dchen1107

@benhxy
Copy link
Contributor Author

benhxy commented Oct 8, 2020

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2020
@benhxy
Copy link
Contributor Author

benhxy commented Oct 12, 2020

/test pull-kubernetes-integration

@benhxy
Copy link
Contributor Author

benhxy commented Oct 12, 2020

/test pull-kubernetes-node-e2e

@benhxy
Copy link
Contributor Author

benhxy commented Oct 12, 2020

/test pull-kubernetes-integration

@benhxy
Copy link
Contributor Author

benhxy commented Oct 12, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@benhxy
Copy link
Contributor Author

benhxy commented Oct 14, 2020

/test pull-kubernetes-integration

@benhxy
Use host IP instead of localhost for control plane component kubeconf…
49afcfa 
…ig files.

This is a part of work to allow control plane components to be moved off hostNetwork.
@benhxy
Copy link
Contributor Author

benhxy commented Oct 22, 2020

/assign cheftako

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benhxy, dchen1107, roycaihw, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit e850fa6 into kubernetes:master Oct 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 23, 2020
liggitt
liggitt reviewed Dec 8, 2020
View reviewed changes
cluster/gce/gci/configure-helper.sh

local kube_apiserver="localhost"
if [[ ${KUBECONFIG_USE_HOST_IP:-} == "true" ]] ; then
kube_apiserver=$(hostname -i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ok, it produces a kubeconfig that sends a replayable credential over an unverified TLS connection. Reverting in 1.20.1, can bring this back in in 1.21 with a verified TLS connection if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@vinayakankugoyal vinayakankugoyal vinayakankugoyal approved these changes

@mml mml Awaiting requested review from mml

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@cheftako cheftako

@roycaihw roycaihw

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@benhxy @k8s-ci-robot @vinayakankugoyal @roycaihw @dchen1107 @liggitt @cheftako