Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vsphere disk detach failure #95447

Merged
merged 1 commit into from Oct 13, 2020
Merged

Fix vsphere disk detach failure #95447

merged 1 commit into from Oct 13, 2020

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Oct 9, 2020 •
edited

Fixes #95121

/kind bug
/sig storage

/assign @divyenpatel @jsafrane

Fix vsphere detach failure for static PVs

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

@gnufied: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 9, 2020
@gnufied gnufied changed the title Fix disk detach failure Fix vsphere disk detach failure Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2020
@gnufied
Copy link
Member Author

gnufied commented Oct 9, 2020

/priority-important-soon

@gnufied
Copy link
Member Author

gnufied commented Oct 9, 2020

cc @kubernetes/sig-storage-bugs

@msau42
Copy link
Member

msau42 commented Oct 9, 2020

cc @yuga711

yuga711
yuga711 reviewed Oct 9, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go
}

volPath = vclib.RemoveStorageClusterORFolderNameFromVDiskPath(volPath)
canonicalPath, pathFetchErr := getcanonicalVolumePath(ctx, vm.Datacenter, volPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't kubevols/disk.vmdk require similar canonical volumepath conversion? How is that handled today?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for dynamically provisioned volumes - canonical path is saved in PV and hence gets used for detach and attach.

@gnufied
Copy link
Member Author

gnufied commented Oct 12, 2020

/retest

divyenpatel
divyenpatel reviewed Oct 12, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go
}

volPath = vclib.RemoveStorageClusterORFolderNameFromVDiskPath(volPath)
canonicalPath, pathFetchErr := getcanonicalVolumePath(ctx, vm.Datacenter, volPath)
// if canonicalPath is not empty string and pathFetchErr is nil then we can use canonical path to perform detach
if canonicalPath != "" && pathFetchErr == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fail the attach operation if we fail to get canonicalVolumePath and pathFetchErr is no nil?

divyenpatel
divyenpatel approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@divyenpatel
Copy link
Member

please squash all your commits.

@gnufied
Fix vsphere disk detach failing
5627771 
Make inability to fetch canonicalPath non-fatal error
Throw error if we can't fetch canonicalPath on attach
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e799c85 into kubernetes:master Oct 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 13, 2020
@yuga711 yuga711 mentioned this pull request Dec 14, 2020
Closed
@yuga711 yuga711 mentioned this pull request Feb 17, 2021
Closed
6 tasks
@gnufied gnufied mentioned this pull request Jun 15, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 17, 2021
Closed
@gnufied gnufied mentioned this pull request Aug 20, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 10, 2021
@k8s-ci-robot
Merge pull request #104485 from gnufied/automated-cherry-pick-of-#954…
07ce8b6 
…47-upstream-release-1.19

Automated cherry pick of #95447: Fix vsphere disk detach failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuga711 yuga711 yuga711 left review comments

@divyenpatel divyenpatel divyenpatel approved these changes

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

Assignees

@jsafrane jsafrane

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Detaching a statically provisioned vSphere PV with folder name in path does not work
7 participants
@gnufied @k8s-ci-robot @msau42 @divyenpatel @fejta-bot @yuga711 @jsafrane