fix: smb valid path error

[andyzhangx]

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: smb valid path error, ported from kubernetes/utils#188

isValidPath func error should be ignored since if password changed, it would return following access error:

PathValid(\\xxx\share) failed with returned output: Test-Path : Access is denied

By that case, should remove original SMB remote path and mount again.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/assign @jingxu97

Does this PR introduce a user-facing change?:

fix: smb valid path error

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: smb valid path error

/priority important-soon
/sig storage
/triage accepted

[andyzhangx]

/retest

[andyzhangx]

@jingxu97 looks like the flush disk operation did not fix the data corruption issue on Windows:

/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/dynamic_provisioning_test.go:587
Unexpected error:
    <*errors.errorString | 0xc0003b06c0>: {
        s: "Failed to find \"hello world\r\nhello world\r\n\", last result: \"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00hello world\r\n\"",
    }
    Failed to find "hello world
    hello world
    ", last result: "�������������hello world
    "
occurred
/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/testsuites/testsuites.go:637

[andyzhangx]

/test pull-kubernetes-e2e-azure-disk-windows

[andyzhangx]

/test pull-kubernetes-e2e-azure-disk-windows

[jingxu97]

@jingxu97 looks like the flush disk operation did not fix the data corruption issue on Windows:

/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/dynamic_provisioning_test.go:587
Unexpected error:
    <*errors.errorString | 0xc0003b06c0>: {
        s: "Failed to find \"hello world\r\nhello world\r\n\", last result: \"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00hello world\r\n\"",
    }
    Failed to find "hello world
    hello world
    ", last result: "�������������hello world
    "
occurred
/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/testsuites/testsuites.go:637

So this test already has the fix I assume? My test failed mostly with empty file like ""\x00\x00\x00\x00\x00\x00\x..." without having the hello world context at all. The tetst is creating a pod with a volume, delete it, and create a second one to read the context. What your test is doing?

[andyzhangx]

/testsuites/testsuites.g

@jingxu97 it's create a deployment object, write and read to it, delete the pod and write and read to it again, looks like it's the same

[andyzhangx]

/test pull-kubernetes-e2e-azure-disk-windows

[andyzhangx]

/testsuites/testsuites.g

@jingxu97 it's create a deployment object, write and read to it, delete the pod and write and read to it again, looks like it's the same

it's a random failure as you could see @jingxu97

[jingxu97]

/testsuites/testsuites.g

@jingxu97 it's create a deployment object, write and read to it, delete the pod and write and read to it again, looks like it's the same

it's a random failure as you could see @jingxu97

y, it is random. But it always happen if you run a number of times. I remember after adding writevolumecache call, it will not happen again for my case.

[andyzhangx]

@jingxu97 could you review this PR? thanks.

[jingxu97]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/mount-utils/OWNERS [jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment