Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable benchmark by matching test config #95608

Merged
merged 1 commit into from Nov 9, 2020
Merged

enable benchmark by matching test config #95608

merged 1 commit into from Nov 9, 2020

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Oct 15, 2020

Change kubernetes/test-infra@fc3e91a from 105 -> 90 causes this test
not to be run.

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:
Enables test that has not been running. Runs both in dockerd and containerd as separate prow jobs
https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-benchmark&sort-by-name=
https://testgrid.k8s.io/sig-node-containerd#node-e2e-benchmark
I'm assuming good faith that someone does want this to run.
It has not been running since June.
I think we do not need it and we should remove these tests/benchmarks.

Which issue(s) this PR fixes:
Found while investigating #95043

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/cc @dims @bart0sh
/assign @dchen1107

@MHBauer
enable benchmark by matching test config
2412578 
Change kubernetes/test-infra@fc3e91a from 105 -> 90 causes this test
not to be run.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

@MHBauer: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 15, 2020
@MHBauer
Copy link
Contributor Author

MHBauer commented Oct 15, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 15, 2020
@MHBauer
Copy link
Contributor Author

MHBauer commented Oct 15, 2020

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Oct 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2020
@MHBauer
Copy link
Contributor Author

MHBauer commented Oct 20, 2020

/assign @derekwaynecarr

@dims
Copy link
Member

dims commented Oct 22, 2020

/approve

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dims, MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1d6bd25 into kubernetes:master Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@dims dims Awaiting requested review from dims

Assignees

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MHBauer @k8s-ci-robot @bart0sh @dims @derekwaynecarr @dchen1107