Promote ReplicationController lifecycle test - +7 endpoint coverage #95713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Riaan Kleinhans <riaan@ii.coop>
k8s-ci-robot
added
release-note-none
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
sig/apps
8 tasks
|
/test pull-kubernetes-conformance-image-test |
|
/test pull-kubernetes-conformance-kind-ipv6-parallel |
Riaankl
moved this from Done
to Promotion PRs Needing Approval
in conformance-definition
|
/test pull-kubernetes-conformance-image-test |
|
testgrid shows zero flakes for quite a while I have It seems those jobs are a bit flakey themselves, but I feel comfortable with the test itself. |
|
/assign @johnbelamaric @spiffxp |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, Riaankl, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
conformance-definition
automation
moved this from Promotion PRs Needing Approval
to Done
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:
getApiregistrationAPIGroup
replaceCoreV1NamespacedReplicationControllerStatus
readCoreV1NamespacedReplicationControllerStatus
patchCoreV1NamespacedReplicationControllerStatus
patchCoreV1NamespacedReplicationControllerScale
patchCoreV1NamespacedReplicationController
listCoreV1ReplicationControllerForAllNamespaces
deleteCoreV1CollectionNamespacedReplicationController
Which issue(s) this PR fixes:
Fixes #90881
Testgrid Link:
Testgrid
Special notes for your reviewer:
Adds +7 endpoint test coverage (good for conformance)
Does this PR introduce a user-facing change?:
Release note:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig testing
/sig architecture
/area conformance