Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax validation for CSIVolumeFSGroupPolicy and move to beta #95739

Merged
merged 9 commits into from Nov 13, 2020
Merged

Relax validation for CSIVolumeFSGroupPolicy and move to beta #95739

merged 9 commits into from Nov 13, 2020

Conversation

huffmanca
Copy link
Contributor

@huffmanca huffmanca commented Oct 20, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Relaxes validation for CSIVolumeFSGroupPolicy values. We plan to introduce a new enum in 1.21, and without this change the enum will result in errors in downgrade scenarios. This PR also moves this field to beta.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

@huffmanca: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2020
@huffmanca
Copy link
Contributor Author

/sig-storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2020
@huffmanca huffmanca changed the title Relax validation for CSIVolumeFSGroupPolicy Relax validation for CSIVolumeFSGroupPolicy and move to beta Oct 21, 2020
@huffmanca
Copy link
Contributor Author

/assign msau42

@msau42 ,

Per the discussion in the CSI meetup, I'm assigning this to you for review.

@huffmanca huffmanca force-pushed the relax-csi-fsgroup-validation branch 2 times, most recently from e7816e1 to 7d6a8cf Compare October 22, 2020 14:21
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-bazel-test

@huffmanca
Copy link
Contributor Author

/retest

3 similar comments
@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@msau42
Copy link
Member

msau42 commented Oct 22, 2020

/assign @gnufied

msau42
msau42 reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/storage/csi_mock_volume.go

// kube-scheduler may need some time before it gets the CSIDriver object.
// Without them, scheduling doesn't run as expected by the test.
syncDelay := 5 * time.Second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a bug to investigate this later?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
smarterclayton
smarterclayton reviewed Nov 12, 2020
View reviewed changes
pkg/apis/storage/validation/validation.go Outdated
// ValidateCSIDriver validates a CSIDriver.
func ValidateCSIDriver(csiDriver *storage.CSIDriver) field.ErrorList {
allErrs := field.ErrorList{}
allErrs := apivalidation.ValidateObjectMeta(&csiDriver.ObjectMeta, false, ValidateCSIDriverName, field.NewPath("metadata"))
// We have an additional name check to verify the length and lowercase the name
allErrs = append(allErrs, apivalidation.ValidateCSIDriverName(csiDriver.Name, field.NewPath("name"))...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this anymore (the method above calls it)

@smarterclayton
Copy link
Contributor

/approve

Meets the bar for promotion, the validation and API errors turned out not to be an issue, I see no reason from the sig or proposal not to approve.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, msau42, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@huffmanca huffmanca mentioned this pull request Nov 12, 2020
Closed
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@msau42
Copy link
Member

msau42 commented Nov 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2020 •
edited

@huffmanca: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-azure-disk-windows ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-azure-disk-windows
pull-publishing-bot-validate ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-publishing-bot-validate
pull-kubernetes-e2e-azure-file-windows ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-azure-file-windows
pull-kubernetes-e2e-aks-engine-azure ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-aks-engine-azure
pull-kubernetes-e2e-gce-network-proxy-http-connect ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-gce-network-proxy-http-connect
pull-kubernetes-e2e-azure-file ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-azure-file
pull-kubernetes-e2e-azure-disk-vmss ca7ea85092e718fb2cfae01316dd9b5398be05da link /test pull-kubernetes-e2e-azure-disk-vmss

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@msau42
Copy link
Member

msau42 commented Nov 12, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 198b2fd into kubernetes:master Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@huffmanca huffmanca mentioned this pull request Nov 13, 2020
Merged
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@msau42 msau42 msau42 left review comments

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@jsafrane jsafrane

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@huffmanca @k8s-ci-robot @msau42 @gnufied @kikisdeliveryservice @saikat-royc @pohly @jsafrane @smarterclayton @leilajal