Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Update the frontend IP config when the service's pipName annotation is changed #95813

Merged
merged 1 commit into from Oct 26, 2020
Merged

Azure: Update the frontend IP config when the service's pipName annotation is changed #95813

merged 1 commit into from Oct 26, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Oct 23, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:
When the service.beta.kubernetes.io/azure-pip-name annotation is changed, the frontend IP configuration fails to refer to the new public IP resource, but the previous public IP resource would be deleted. This leads to the service pointing to a zombie IP address. This PR fixes the issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update the frontend IP config when the service's `pipName` annotation is changed

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/area provider/azure
/sig cloud-provider
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 23, 2020
@k8s-ci-robot
Copy link
Contributor

@nilo19: The label(s) area/provider/azire cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:
When the service.beta.kubernetes.io/azure-pip-name annotation is changed, the frontend IP configuration fails to refer to the new public IP resource, but the previous public IP resource would be deleted. This leads to the service pointing to a zombie IP address. This PR fixes the issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update the frontend IP config when the service's `pipName` annotation is changed

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/area provider/azire
/sig cloud-provider
/priority important-soon
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2020
@nilo19
Copy link
Member Author

nilo19 commented Oct 23, 2020

/retest

@nilo19
Copy link
Member Author

nilo19 commented Oct 23, 2020

/retest

feiskyer
feiskyer reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@feiskyer feiskyer added this to In progress in Provider Azure via automation Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16e18a5 into kubernetes:master Oct 26, 2020
Provider Azure automation moved this from In progress to Done Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 26, 2020
@nilo19 nilo19 deleted the bug/fix-pip-name branch October 26, 2020 01:07
@nilo19 nilo19 mentioned this pull request Oct 26, 2020
Closed
@asubmani asubmani mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Provider Azure
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilo19 @k8s-ci-robot @feiskyer