-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: Update the frontend IP config when the service's pipName
annotation is changed
#95813
Conversation
@nilo19: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
ab6e455
to
7d987f0
Compare
/retest |
staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go
Outdated
Show resolved
Hide resolved
7d987f0
to
87a4805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the
service.beta.kubernetes.io/azure-pip-name
annotation is changed, the frontend IP configuration fails to refer to the new public IP resource, but the previous public IP resource would be deleted. This leads to the service pointing to a zombie IP address. This PR fixes the issue.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/area provider/azure
/sig cloud-provider
/priority important-soon
/triage accepted