Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubectl - flush profiling when interrupting a long running command #96019

Merged
merged 1 commit into from Nov 3, 2020
Merged

Kubectl - flush profiling when interrupting a long running command #96019

merged 1 commit into from Nov 3, 2020

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Oct 29, 2020

Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it: kubectl doesn't flushes the profiling files when the run is interrupted. This PR adds the termination handling, and flushes the profile before finishing the program

Which issue(s) this PR fixes:
Fixes #96017

Special notes for your reviewer:
Actually when kubectl gets an error, it exists with os.Exit(1) from cmdutil.CheckErr which doesn't allow the profiler to have a chance to flush and stop either.

This PR solves only the 'control-c' problem, but I can take a further look also into how to deal with the cmdutil.CheckErr to flush the profiling when an error happens (as a timeout while waiting)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2020
@rikatz
Copy link
Contributor Author

rikatz commented Oct 29, 2020

/sig cli
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2020
@rikatz
Copy link
Contributor Author

rikatz commented Oct 29, 2020

/assign @soltysh

@rikatz
kubectl flush profiling when get a sigterm
912d967 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
@rikatz rikatz changed the title Kubectl - flush profile when interrupting a long running command Kubectl - flush profiling when interrupting a long running command Oct 29, 2020
soltysh
soltysh approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3c2da35 into kubernetes:master Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

No kubectl profile when a sigterm occurs
3 participants
@rikatz @k8s-ci-robot @soltysh