-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that disabling enable-cadvisor-json-endpoints
flag does not disable stats summary endpoint
#96483
Comments
/kind documentation |
@ehashman: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign This should be updated in |
To summarize a conversation in slack, it appears there is a documented procedure for updating the website found at https://kubernetes.io/docs/contribute/generate-ref-docs/kubectl/ In any case, we likely should keep this issue open until both the change to options.go and an associated website change are merged. |
@joadavis can you link to the Slack convo? |
Can do - https://kubernetes.slack.com/archives/C20HH14P7/p1606936008188200 The conversation ended with a question whether there is a bug that would prevent an automated update of the documentation or if we need to submit a PR now that the fix has merged. I searched for an issue but didn't find a match. So we can either try to find someone on sig-docs who might know if there is an issue if it should be updated automagically, or just fix the doc if the website didn't get updated (and I just checked the master branch and it has not been updated yet). |
…ot disable stats summary endpoint Update the help text for kubelet's enable-cadvisor-json-endpoints flag to explicitly mention that it has no effect over the /stats/summary endpoint. This matches https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/options/options.go#L372 created to fix kubernetes/kubernetes#96483 .
Just in case that is the right answer, I created the PR. |
I think the website gets autogenerated upon point releases but that'd be a good thing to clarify with the website team. I'll leave a comment asking as much. |
What would you like to be added:
Update the help text for kubelet's
enable-cadvisor-json-endpoints
flag to explicitly mention that it has no effect over the/stats/summary
endpoint.Why is this needed:
The help text for kubelet's
enable-cadvisor-json-endpoints
flag describes it as "Enable cAdvisor json/spec
and/stats/*
endpoints." which would seem to include/stats/summary
, however this is not the case as that endpoint is required by kube-metrics-server and exposes stats from cadvisor or CRI (depending on the stat provider selected internally).Related Issues:
#68522
/sig node
/sig instrumentation
/kind documentation
The text was updated successfully, but these errors were encountered: