Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang.org/x/net and golang.org/x/sys #96549

Merged
merged 1 commit into from Nov 13, 2020

Conversation

caesarxuchao
Copy link
Member

This PR updated golang/net and golang/sys to the latest.

#96076 was reverted because golang/sys@6fcdbc0 dropped support for direct syscall supports in darwin, which broke k8s builds on darwin.

As pointed out in #96348 (comment), golang/sys added back the support in golang/sys@c5abc1b.

/kind bug
/sig api-machinery
/assign @liggitt
/cc @aojea @dims

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 13, 2020
@caesarxuchao
Copy link
Member Author

caesarxuchao commented Nov 13, 2020

/test pull-kubernetes-cross

I suppose this is the test that includes the darwin build.

@aojea
Copy link
Member

aojea commented Nov 13, 2020

/retest
/lgtm
I've verified this compiles for darwin/amd64

+++ [1113 11:29:05] Building tarball: manifests
+++ [1113 11:29:05] Starting tarball: client darwin-amd64

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@dims
Copy link
Member

dims commented Nov 13, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 13, 2020
@dims
Copy link
Member

dims commented Nov 13, 2020

/approve
/lgtm
/milestone v1.20
/triage accepted
/priority important-soon
/area code-organization

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2020
@dims
Copy link
Member

dims commented Nov 13, 2020

/approve
/lgtm
/assign @smarterclayton

@liggitt @smarterclayton Needs root approval

@liggitt
Copy link
Member

liggitt commented Nov 13, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@aojea
Copy link
Member

aojea commented Nov 13, 2020

/retest

2020/11/13 11:56:38 Image pull was unsuccessful: unable to save remote image k8s.gcr.io/build-image/debian-iptables@sha256:e30919918299988b318f0208e7fd264dee21a6be9d74bbd9f7fc15e78eade9b4: unable to write image layers: unable to write image layer: unable to write the contents of layer 0 to /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/external/debian-iptables-amd64/image/000.tar.gz: read tcp 10.60.70.234:54606->209.85.145.128:443: read: connection reset by peer

Im seeing this error many times lately :thinking: , who is 209.85.145.128` , @spiffxp do yo know? is this the pull through cache for images?

@dims
Copy link
Member

dims commented Nov 13, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@aojea
Copy link
Member

aojea commented Nov 13, 2020

/retest

Error from server (AlreadyExists): namespaces "namespace-1605282573-27849" already exists
!!! [1113 15:49:33] Call tree:
!!! [1113 15:49:33]  1: /home/prow/go/src/k8s.io/kubernetes/test/cmd/../../test/cmd/core.sh:73 create_and_use_new_namespace(...)
!!! [1113 15:49:33]  2: /home/prow/go/src/k8s.io/kubernetes/test/cmd/../../third_party/forked/shell2junit/sh2ju.sh:47 run_pod_tests(...)
!!! [1113 15:49:33]  3: /home/prow/go/src/k8s.io/kubernetes/test/cmd/../../third_party/forked/shell2junit/sh2ju.sh:112 eVal(...)
!!! [1113 15:49:33]  4: /home/prow/go/src/k8s.io/kubernetes/test/cmd/legacy-script.sh:131 juLog(...)
!!! [1113 15:49:33]  5: /home/prow/go/src/k8s.io/kubernetes/test/cmd/legacy-script.sh:507 record_command(...)
!!! [1113 15:49:33]  6: hack/make-rules/test-cmd.sh:184 runTests(...)

@k8s-ci-robot k8s-ci-robot merged commit 85cd7c5 into kubernetes:master Nov 13, 2020
@caesarxuchao
Copy link
Member Author

@aojea @dims, thanks for taking care of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants