Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix all keps links 404 for kep folder migration #98049

Merged
merged 1 commit into from Feb 2, 2021
Merged

fix all keps links 404 for kep folder migration #98049

merged 1 commit into from Feb 2, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 14, 2021 •
edited

What type of PR is this?
/kind documentation
/kind cleanup

What this PR does / why we need it:
Since enhancements changed the KEP folder structure and many KEP link breaks.

It seems that using enhancements issues/PR link is better than master links

Which issue(s) this PR fixes:
part of kubernetes/enhancements#2220

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 14, 2021

/test pull-kubernetes-e2e-gce-storage-slow

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 14, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 15, 2021 •
edited

/assign @alejandrox1
/assign @deads2k @jsafrane @mrunalp @sttts @tpepper Sorry to include so many owners.
For files in your sig.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Jan 15, 2021

/lgtm
/approve

@pacoxu pacoxu mentioned this pull request Jan 20, 2021
Closed
@pacoxu

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 22, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 28, 2021
@pacoxu
fix all keps links 404 for kep folder migration
a10bdfe 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 1, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 1, 2021

/test pull-kubernetes-e2e-azure-disk-windows

@tpepper
Copy link
Member

tpepper commented Feb 1, 2021

/assign @wilsonehusin @justaugustus
/unassign @tpepper
for CHANGELOG/

@wilsonehusin
Copy link
Contributor

/lgtm
/approve
for CHANGELOG/

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 1, 2021

/assign @deads2k @liggitt @jsafrane

@liggitt
Copy link
Member

liggitt commented Feb 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mrunalp, pacoxu, sttts, wilsonehusin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit ee2b7a5 into kubernetes:master Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@pacoxu pacoxu deleted the enhancements/redir-links branch June 23, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@mrunalp mrunalp

@justaugustus justaugustus

@sttts sttts

@jsafrane jsafrane

@alejandrox1 alejandrox1

@deads2k deads2k

@wilsonehusin wilsonehusin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet