Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links to KEPs in swagger.json #98216

Closed
wants to merge 1 commit into from
Closed

fix broken links to KEPs in swagger.json #98216

wants to merge 1 commit into from

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Jan 20, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Pod reference contains broken links to KEP.

Which issue(s) this PR fixes:

ref kubernetes/website#26168

Special notes for your reviewer:

The same links exist in the files below. They should be modified manually?

$ git grep -l "https://git.k8s.io/enhancements/keps/sig-node/runtime-class.md"
staging/src/k8s.io/api/core/v1/generated.proto
staging/src/k8s.io/api/core/v1/types.go
staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go
staging/src/k8s.io/api/node/v1alpha1/generated.proto
staging/src/k8s.io/api/node/v1alpha1/types.go
staging/src/k8s.io/api/node/v1alpha1/types_swagger_doc_generated.go
staging/src/k8s.io/api/node/v1beta1/generated.proto
staging/src/k8s.io/api/node/v1beta1/types.go
staging/src/k8s.io/api/node/v1beta1/types_swagger_doc_generated.go
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/testdata/swagger.json
staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2/api.pb.go
staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2/api.proto
staging/src/k8s.io/kubectl/testdata/openapi/swagger.json
$ git grep -l "https://git.k8s.io/enhancements/keps/sig-network/0007-pod-ready%2B%2B.md"
pkg/apis/core/types.go
staging/src/k8s.io/api/core/v1/generated.proto
staging/src/k8s.io/api/core/v1/types.go
staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/testdata/swagger.json
staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
staging/src/k8s.io/kubectl/testdata/openapi/swagger.json
$ git grep -l "https://git.k8s.io/enhancements/keps/sig-node/20190226-pod-overhead.md"
pkg/apis/core/types.go
pkg/apis/node/types.go
staging/src/k8s.io/api/core/v1/generated.proto
staging/src/k8s.io/api/core/v1/types.go
staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go
staging/src/k8s.io/api/node/v1alpha1/generated.proto
staging/src/k8s.io/api/node/v1alpha1/types.go
staging/src/k8s.io/api/node/v1alpha1/types_swagger_doc_generated.go
staging/src/k8s.io/api/node/v1beta1/generated.proto
staging/src/k8s.io/api/node/v1beta1/types.go
staging/src/k8s.io/api/node/v1beta1/types_swagger_doc_generated.go
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/testdata/swagger.json
staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
staging/src/k8s.io/kubectl/testdata/openapi/swagger.json

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[Other doc]: https://kubernetes.io/docs/reference/kubernetes-api/workloads-resources/pod-v1/

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oke-py
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oke-py
Copy link
Contributor Author

oke-py commented Jan 24, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 24, 2021

@oke-py: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-verify 7d30b14 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ehashman
Copy link
Member

ehashman commented Feb 1, 2021

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2021
@fedebongio
Copy link
Contributor

/assign @yliaog
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2021
@yliaog
Copy link
Contributor

yliaog commented Feb 3, 2021

the file is automatically generated, please take a look at k8s.io/kube-openapi/cmd/openapi-gen/

Copy link

@Cheef5 Cheef5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Cheef5: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@oke-py: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2021
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 8, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants