Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Updated test for StatefulSet Replica scaling to include Patch Scale +1 endpoint #98125

Closed
3 of 6 tasks
riaankleinhans opened this issue Jan 17, 2021 · 1 comment · Fixed by #98126
Closed
3 of 6 tasks
Labels
area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@riaankleinhans
Copy link
Contributor

riaankleinhans commented Jan 17, 2021

Progress [3/6]

Identifying an untested feature Using APISnoop

According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested.

with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints

SELECT
  endpoint,
  -- k8s_action,
  -- path,
  -- description,
  kind
  FROM testing.untested_stable_endpoint
  where eligible is true
    and endpoint like '%StatefulSetScale%'
  --and category = 'core'
  order by kind, endpoint desc
  limit 25;
               endpoint                | kind
---------------------------------------|-------
 patchAppsV1NamespacedStatefulSetScale | Scale
(1 row)


# Verifying increase in coverage with APISnoop


```sql-mode
select distinct  endpoint, right(useragent,73) AS useragent
from testing.audit_event
-- where useragent ilike '%subresource%'
 where endpoint ilike '%AppsV1NamespacedStatefulSetScale%'
 and release_date::BIGINT > round(((EXTRACT(EPOCH FROM NOW()))::numeric)*1000,0) - 60000
and useragent like 'e2e%'
order by endpoint
limit 30;

                endpoint                 |                                 useragent
-----------------------------------------|---------------------------------------------------------------------------
 patchAppsV1NamespacedStatefulSetScale   |  [StatefulSetBasic] should have a working scale subresource [Conformance]
 readAppsV1NamespacedStatefulSetScale    |  [StatefulSetBasic] should have a working scale subresource [Conformance]
 replaceAppsV1NamespacedStatefulSetScale |  [StatefulSetBasic] should have a working scale subresource [Conformance]
(3 rows)

Final notes

If a test with these calls gets merged, test coverage will go up by 1 point

This test is also created with the goal of conformance promotion.


/sig testing

/sig architecture

/area conformance

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests labels Jan 17, 2021
@k8s-ci-robot
Copy link
Contributor

@Riaankl: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 17, 2021
@riaankleinhans riaankleinhans added this to Sorted Backlog / On hold Issues in conformance-definition Jan 25, 2021
conformance-definition automation moved this from Sorted Backlog / On hold Issues to Done Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants