Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check externalNameService more time #98521

Merged

Conversation

JornShen
Copy link
Member

@JornShen JornShen commented Jan 28, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

add more check to externalNameService

the failed test error as fellow:

Jan 15 09:43:03.808: INFO: Creating new exec pod
Jan 15 09:43:08.368: INFO: Running '/workspace/kubernetes/platforms/linux/amd64/kubectl --server=https://34.105.6.162 --kubeconfig=/workspace/.kube/config --namespace=services-5563 exec execpod4sxhv -- /bin/sh -x -c nslookup clusterip-service.services-5563.svc.cluster.local'
Jan 15 09:43:10.121: INFO: rc: 1
Jan 15 09:43:10.121: FAIL: Unexpected error:
    <*errors.errorString | 0xc002cf2840>: {
        s: "ExternalName service \"services-5563/execpod4sxhv\" must resolve to IP",
    }
    ExternalName service "services-5563/execpod4sxhv" must resolve to IP
occurred

Full Stack Trace
k8s.io/kubernetes/test/e2e/network.glob..func24.17()
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/service.go:1773 +0x465
k8s.io/kubernetes/test/e2e.RunE2ETests(0xc0038b8480)
	_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/e2e.go:130 +0x36c
k8s.io/kubernetes/test/e2e.TestE2E(0xc0038b8480)
	_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/e2e_test.go:144 +0x2b
testing.tRunner(0xc0038b8480, 0x4fe76e8)
	/usr/local/go/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1168 +0x2b3

It failed in checking externalName type service effective.
And I found the case only check it once.

_, stderr, err := framework.RunHostCmdWithFullOutput(pod.Namespace, pod.Name, cmd)

I think check it once is not enough. The work item is DNS side. But we can control the order of dns work completed and
our check. So add more check times will be more reasonable.

Which issue(s) this PR fixes:

Fix #98104

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2021
@k8s-ci-robot
Copy link
Contributor

@JornShen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2021
@JornShen JornShen force-pushed the check_externalNameService_more_time branch from 4bfa477 to 6d084f2 Compare January 28, 2021 11:29
@JornShen
Copy link
Member Author

/cc @aojea @spiffxp

test/e2e/network/service.go Outdated Show resolved Hide resolved
@JornShen JornShen force-pushed the check_externalNameService_more_time branch from 6d084f2 to 633f0ad Compare January 29, 2021 03:29
@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Jan 29, 2021
@JornShen
Copy link
Member Author

updated. PTAL :)
@aojea

@JornShen JornShen force-pushed the check_externalNameService_more_time branch from 633f0ad to ff22520 Compare January 29, 2021 08:21
@JornShen JornShen force-pushed the check_externalNameService_more_time branch from ff22520 to 415fe23 Compare January 29, 2021 11:04
@aojea
Copy link
Member

aojea commented Jan 29, 2021

/lgtm
/assign @MrHohn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@JornShen
Copy link
Member Author

/test pull-kubernetes-e2e-kind

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JornShen, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 29, 2021

@JornShen: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-ubuntu-gce-network-policies 6d084f25d2aa30cb83634dd9391409bd8a6c3302 link /test pull-kubernetes-e2e-ubuntu-gce-network-policies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aojea
Copy link
Member

aojea commented Jan 29, 2021

/retest
storage flake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test] [sig-network] Services should be able to change the type from ClusterIP to ExternalName
5 participants