New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check externalNameService more time #98521
check externalNameService more time #98521
Conversation
@JornShen: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4bfa477
to
6d084f2
Compare
6d084f2
to
633f0ad
Compare
updated. PTAL :) |
633f0ad
to
ff22520
Compare
ff22520
to
415fe23
Compare
/lgtm |
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JornShen, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
@JornShen: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
add more check to externalNameService
the failed test error as fellow:
It failed in checking
externalName
type service effective.And I found the case only check it once.
kubernetes/test/e2e/framework/service/jig.go
Line 991 in 9f2f1b8
I think check it once is not enough. The work item is DNS side. But we can control the order of dns work completed and
our check. So add more check times will be more reasonable.
Which issue(s) this PR fixes:
Fix #98104
Does this PR introduce a user-facing change?: