[WIP] [release-4.6] Rebase onto v1.19.12 #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we're pulling the relnotes team into review, the changes to reviewers will happen a little more frequently, which means we'll have the same issue of needing a top-level approver to do updates that we were trying to avoid by creating the subdirectory in the first place. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 5639cd9)
Dan and Sascha are senior Release Managers, SIG Release leadership, and have already been giving thoughtful reviews of the content in this directory. Adding them as reviewers to spread the load of SIG Release eyes on content. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 1a43c65)
Creates a few agnhost related functions that creates agnhost pods / containers for general purposes. The following commits will refactor tests to use those functions.
Make pre provisioned snapshots using CSI driver by 1. Take a dynamic snapshot with retain policy 2. Delete the dynamic snapshot and content 3. Create a preprovisioned snapshot with snapshotHandle This commit adds a preprovisiond test pattern, all snapshots made using create snapshot resource become prepv snapshots. All exisitng test cases now run again with prepv snapshots.
Prepv snapshots only need to specify driver.
…ime taken on prow.
…snapcontent name instead
A previous commit created a few agnhost related functions that creates agnhost pods / containers for general purposes. Refactors tests to use those functions.
This fixes a problem when using the framework helper e2epod.CreateExecPodOrFail() more than once in the same test. The problem is that this function was creating pods with both the pod.Name and pod.GenerateName set. The second pod failed to be created with a 500 with Reason ServerTimeout indicating a unique name could not be found in the time allotted, xref https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/
e2e tests should log stdout / stderr of failed commands executed via PodExec. "command terminated with exit code 1" is not really useful.
Add a separate in-tree gcepd driver for windows cluster because it does not support certain features as Linux driver. Change-Id: I2fca86b3f32f17db7703c46a36944d9ee51f355f
Update snapshottable and disable disruptive test for Windows Change-Id: I9d6beb25078c1941e405bf61545caae30326ddd1
Update storage test suits to enable some tests on Windows Change-Id: I1f596bb9f7a0f41ae398aec43406ee5c753cdce3
Update storage topology tests setup for Windows Change-Id: I9a2773b91806a10553db06f61f7259db4df71c3b
…d provider OpenStack cloud provider must not use nil when provisioning a Cinder volume.
Instead of allowing the cloud provider to guess at the zones that should be applied for a cluster under test, allow the explicit list of zones to consider to be passed as a new test context flag -gce-zones. Only the GCE test cloud provider recognizes this value because only the GCE test cloud provider makes assumptions about zones for verifying values, and the default assumptions for GKE do not always match non-GKE providers.
A number of e2e tests are useful to run after the system has been disrupted or is in the progress of being disrupted, but the current suite and test logic blocks progress waiting for all nodes to be healthy. By passing -1 to --minStartupPods or --allowed-not-ready-nodes flags the caller can bypass wait logic before and after test suites that would prevent running e2e during disruption. This allows use of parts of the e2e suite during cluster duress to verify that controllers or components still function.
Set informer for the openstack cloud provider to ensure it is properly initialized when reading config from a secret. Upstream 89885 was closed in favor of 96750. Co-authored-by: Hemant Kumar <hekumar@redhat.com>
There is a race when the server is coming up and the subsequent dial on the socket. Fix the race with a PollImmediate retry.
…ingTermination Ensures the pod to be pending termination or be killed, after (*podKillerWithChannel).KillPod has been returned, by limiting one request per pod in (*podKillerWithChannel).KillPod.
…SourcesAreReadyPerQOS
|
@damemi: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
backports/unvalidated-commits
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@damemi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
It looks like I missed something because Which must be from one of the openstack picks |
openshift-ci
bot
added
the
needs-rebase
|
@damemi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
|
@damemi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits sheet: https://docs.google.com/spreadsheets/d/154TrUMoS-xiKjw7sgyMA6upb9WDxaaTu6TEWostnh3U/edit?usp=sharing
I am having trouble with the generated/openshift files. Following the steps in the rebase doc, files like
hyperkube/Dockerfile.rheldon't exist. So I am unable to carry commits that have that file or edit it. Still trying to figure it out