Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Read, Replace and Patch DeploymentScale test +3 endpoints #98988

Merged
merged 1 commit into from Feb 12, 2021

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented Feb 11, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • replaceAppsV1NamespacedDeploymentScale
  • readAppsV1NamespacedDeploymentScale
  • patchAppsV1NamespacedDeploymentScale

Which issue(s) this PR fixes:
Fixes #98936

Testgrid Link:
Testgrid

Special notes for your reviewer:
Adds +3 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/sig apps
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Feb 11, 2021
@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-e2e-kind

Unrelated flake

• Failure [183.358 seconds]
[sig-network] Services
test/e2e/network/framework.go:23
  should serve multiport endpoints from pods  [Conformance] [It]
  test/e2e/framework/framework.go:640
  Feb 11 10:25:04.188: failed to validate endpoints for service 
  multi-endpoint-test in namespace: services-1067
      
  Unexpected error:
      <*errors.errorString | 0xc002b0bd30>: {
          s: "error waithing for service multi-endpoint-test in namespace 
   services-1067 to expose endpoints map[pod1:[100]]: timed out waiting for the condition",
      }
      error waithing for service multi-endpoint-test in namespace 
   services-1067 to expose endpoints map[pod1:[100]]: timed out waiting for the condition
  occurred
  test/e2e/network/service.go:889
------------------------------
{"msg":"FAILED [sig-network] Services should serve multiport endpoints from pods  
[Conformance]","total":-1,"completed":4,"skipped":45,"failed":1,"failures":["
[sig-network] Services should serve multiport endpoints from pods  [Conformance]"]}
skipped 44882 lines unfold_more
[Fail] [sig-network] Services [It] should serve multiport endpoints from pods  [Conformance] 
test/e2e/network/service.go:889

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/assign @soltysh @mattfarina @kow3ns
This is to address 3 untested Apps endpoints

test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
test/e2e/apps/deployment.go Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented Feb 11, 2021

@Riaankl Do we want to also wait for sometime to ensure that Status.Replicas reaches 4 at the end?

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

@Riaankl Do we want to also wait for some time to ensure that Status.Replicas reaches 4 at the end?

I have 3 similar tests for -Scale endpoints and @soltysh said it is not needed as it is not what we are testing.
#98126 (comment)

@dims
Copy link
Member

dims commented Feb 11, 2021

@Riaankl looks like 1 nit from @soltysh is still there, once that it is done LGTM

@dims
Copy link
Member

dims commented Feb 11, 2021

@Riaankl https://github.com/kubernetes/kubernetes/pull/98988/files#r574602452 is still left to be addressed, please squash as well.

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

@Riaankl https://github.com/kubernetes/kubernetes/pull/98988/files#r574602452 is still left to be addressed, please squash as well.

Think I got them all now, thank you.
And rebased.

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-conformance-kind-ga-only-parallel

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-bazel-test

Unrelated flake

--- FAIL: TestSyncPodsDeletesWhenSourcesAreReadyPerQOS (14.00s)
    kubelet_test.go:465: 
        	Error Trace:	kubelet_test.go:465
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestSyncPodsDeletesWhenSourcesAreReadyPerQOS
        	Messages:   	wait should not return error
    kubelet_test.go:470: 
        	Error Trace:	kubelet_test.go:470
        	Error:      	Should be true
skipped 106 lines unfold_more

@Riaankl
Copy link
Contributor Author

Riaankl commented Feb 11, 2021

/test pull-kubernetes-node-e2e

Unrelated flake

• Failure [41.807 seconds]
[k8s.io] Summary API [NodeConformance]
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:635
when querying /stats/summary
_output/local/go/src/k8s.io/kubernetes/test/e2e_node/summary_test.go:43
should report resource usage through the stats api [It]
skipped 2396 lines unfold_more

[Fail] [k8s.io] Summary API [NodeConformance] when querying /stats/summary [It] should report resource usage through the stats api 
_output/local/go/src/k8s.io/kubernetes/test/e2e_node/summary_test.go:344
Ran 158 of 343 Specs in 671.286 seconds
 -- 157 Passed | 1 Failed | 0 Pending | 185 Skipped

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@soltysh
Copy link
Contributor

soltysh commented Feb 12, 2021

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 67fbf41 into kubernetes:master Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 12, 2021
@Riaankl Riaankl added this to Promotion PRs Needing Two Weeks (flake free) in conformance-definition Feb 14, 2021
@spiffxp spiffxp moved this from Promotion PRs Needing Two Weeks (flake free) to Done in conformance-definition Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

Write Read, Replace and Patch DeploymentScale test +3 endpoints
6 participants