New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Read, Replace and Patch DeploymentScale test +3 endpoints #98988
Conversation
/test pull-kubernetes-e2e-kind Unrelated flake
|
/assign @soltysh @mattfarina @kow3ns |
eb5682a
to
8c64daf
Compare
@Riaankl Do we want to also wait for sometime to ensure that Status.Replicas reaches 4 at the end? |
I have 3 similar tests for -Scale endpoints and @soltysh said it is not needed as it is not what we are testing. |
@Riaankl https://github.com/kubernetes/kubernetes/pull/98988/files#r574602452 is still left to be addressed, please squash as well. |
8d467f1
to
a5ffaa0
Compare
Think I got them all now, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
46fea1c
to
7cea43a
Compare
/test pull-kubernetes-conformance-kind-ga-only-parallel |
/test pull-kubernetes-bazel-test Unrelated flake
|
/test pull-kubernetes-node-e2e Unrelated flake
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Riaankl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:
Which issue(s) this PR fixes:
Fixes #98936
Testgrid Link:
Testgrid
Special notes for your reviewer:
Adds +3 endpoint test coverage (good for conformance)
Does this PR introduce a user-facing change?:
Release note:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig testing
/sig architecture
/sig apps
/area conformance