Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella Issue: Apps Endpoints without Conformance test #98640

Closed
riaankleinhans opened this issue Jan 31, 2021 · 8 comments
Closed

Umbrella Issue: Apps Endpoints without Conformance test #98640

riaankleinhans opened this issue Jan 31, 2021 · 8 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@riaankleinhans
Copy link
Contributor

riaankleinhans commented Jan 31, 2021

Purpose of the issue:

This issue is created to collect and share information about apps endpoints without Conformance test.
It also serves to group endpoints by family and indicates what work is underway to prevent duplicate effort.
More information will be added as it becomes available or is discovered during test writing.

The Endpoints groups:

DaemonSet
StatefulSet
Deployment
Replicaset
ControllerRevision

DaemonSet:
Issue 90877 is targeting all 5 remaining DaemonSet endpoints. The test concept has been agreed to be valid in the Conformance meeting of 26 Jan 2021. A pull request would be created soon.

Endpoint Tested Release
replaceAppsV1NamespacedDaemonSetStatus PR100507
readAppsV1NamespacedDaemonSetStatus PR100507
patchAppsV1NamespacedDaemonSetStatus PR100507
listAppsV1DaemonSetForAllNamespaces PR101995
deleteAppsV1CollectionNamespacedDaemonSet PR101995
replaceAppsV1NamespacedDaemonSet 1.10.0
readAppsV1NamespacedDaemonSet 1.10.0
patchAppsV1NamespacedDaemonSet 1.10.0
listAppsV1NamespacedDaemonSet 1.10.0
deleteAppsV1NamespacedDaemonSet 1.10.0
createAppsV1NamespacedDaemonSet 1.10.0

StatefulSet
The patch--StatefulSetScale endpoint is tested by appending an existing conformance test and is ready to be merged by PR 98126

Endpoint Tested Release
patchAppsV1NamespacedStatefulSetScale New 1.21
deleteAppsV1CollectionNamespacedStatefulSet New 1.22
listAppsV1StatefulSetForAllNamespaces New 1.22
patchAppsV1NamespacedStatefulSet New 1.22
patchAppsV1NamespacedStatefulSetStatus New 1.22
readAppsV1NamespacedStatefulSetStatus New 1.22
replaceAppsV1NamespacedStatefulSetStatus New 1.22
createAppsV1NamespacedStatefulSet 1.9.0
deleteAppsV1NamespacedStatefulSet 1.9.0
listAppsV1NamespacedStatefulSet 1.9.0
readAppsV1NamespacedStatefulSet 1.9.0
replaceAppsV1NamespacedStatefulSet 1.9.0
readAppsV1NamespacedStatefulSetScale 1.16.0
replaceAppsV1NamespacedStatefulSetScale 1.16.0

Deployment
The Read-, Replace- and Patch DeploymentScale endpoints would be addressed in a similar way as the StatefulSetScale endpoints.

Endpoint Tested Release
readAppsV1NamespacedDeploymentScale New 1.21
replaceAppsV1NamespacedDeploymentScale New 1.21
patchAppsV1NamespacedDeploymentScale New 1.21
replaceAppsV1NamespacedDeploymentStatus New 1.22
listAppsV1NamespacedDeployment 1.9.0
deleteAppsV1NamespacedDeployment 1.9.0
createAppsV1NamespacedDeployment 1.9.0
readAppsV1NamespacedDeploymentStatus 1.20.0
patchAppsV1NamespacedDeploymentStatus 1.20.0
patchAppsV1NamespacedDeployment 1.20.0
listAppsV1DeploymentForAllNamespaces 1.20.0
deleteAppsV1CollectionNamespacedDeployment 1.20.0
replaceAppsV1NamespacedDeployment 1.12.0
readAppsV1NamespacedDeployment 1.12.0

ReplicaSet:
The Read-, Replace- and Patch ReplicasetScale endpoints would be addressed in a similar way as the StatefulSetScale endpoints.

Endpoint Tested Release
readAppsV1NamespacedReplicaSetScale New 1.21
replaceAppsV1NamespacedReplicaSetScale New 1.21
patchAppsV1NamespacedReplicaSetScale New 1.21
replaceAppsV1NamespacedReplicaSetStatus PR101260
replaceAppsV1NamespacedReplicaSet New 1.21
readAppsV1NamespacedReplicaSetStatus PR101260
patchAppsV1NamespacedReplicaSetStatus PR101260
patchAppsV1NamespacedReplicaSet New 1.21
listAppsV1ReplicaSetForAllNamespaces PR101261
deleteAppsV1CollectionNamespacedReplicaSet PR101261
readAppsV1NamespacedReplicaSet 1.9.0
listAppsV1NamespacedReplicaSet 1.9.0
createAppsV1NamespacedReplicaSet 1.9.0
deleteAppsV1NamespacedReplicaSet 1.16.0

ControllerRevision:
The endpoint does not have Issue / PR addressing their conformance testing and I a good candidate for a "Lifecycle" test.

Endpoint Tested Release
replaceAppsV1NamespacedControllerRevision not tested
readAppsV1NamespacedControllerRevision not tested
patchAppsV1NamespacedControllerRevision not tested
listAppsV1ControllerRevisionForAllNamespaces not tested
deleteAppsV1NamespacedControllerRevision not tested
deleteAppsV1CollectionNamespacedControllerRevision not tested
createAppsV1NamespacedControllerRevision not tested
listAppsV1NamespacedControllerRevision 1.10.0

E2E Test status:

The kubernetes/test/e2e/apps/ folder does contain a lot of work addressing the testing of Apps endpoints only about 50% of the Apps endpoints a tested with test promoted to conformance and one endpoint replaceAppsV1NamespacedReplicaSet show as tested, but not conformance tested.
Therefore it can be concluded that there is not really any valid e2e test that could just be promoted to conformance.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2021
@riaankleinhans
Copy link
Contributor Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2021
@riaankleinhans
Copy link
Contributor Author

/assign @mattfarina @soltysh
Some feedback:
After the last SIG Apps meeting we attended, we discussed the topic in the Conformance meeting and SIG Architecture meetings.

The direction given by SIG Arch is that all GA endpoints that are not disqualified due to the rules for endpoints that can not be tested, should have a conformance test, irrespective of the level of use or if it is a consumer-facing endpoint.

We also did some check of e2e tests that is valid to promotion to conformance but this one shows up one endpoint mentioned above.
/cc @hh

@riaankleinhans
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2021
@riaankleinhans
Copy link
Contributor Author

PR98126 merged to promote patchAppsV1NamespacedStatefulSetScale
PR's for Read, Replace, and Patch of ReplicaSet & Deployment endpoints are merged and could be promoted to conformance by 26 Feb if they show no flakes on the test grid:
ReplicaSet
Deployment
GREAT community effort!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2021
@riaankleinhans
Copy link
Contributor Author

Great work was done on Apps endpoints since the begining of 2021
Only 7 ControllerRevision endpoint remain.
Will be likely bt targeted in 1.24
The Unbrella issue can be closed.
/close

@k8s-ci-robot
Copy link
Contributor

@Riaankl: Closing this issue.

In response to this:

Great work was done on Apps endpoints since the begining of 2021
Only 7 ControllerRevision endpoint remain.
Will be likely bt targeted in 1.24
The Unbrella issue can be closed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

conformance-definition automation moved this from Issues To Triage to Done Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

5 participants