Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conformance metadata release 1.20 #99081

Merged

Conversation

heyste
Copy link
Member

@heyste heyste commented Feb 15, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

#98940 addressed a SIG-Scheduling conformance test that was relocated to SIG-Network by tagging those changes to be part of the 1.21 release. This PR reverts changes made to the 1.20 release conformance metadata which is causing k8s-conformance tests to fail at the moment.

Which issue(s) this PR fixes:

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

Reverting a metadata change that causes failures in tools that test for Kubernetes conformance.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

@heyste: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2021
@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/sig architecture

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/test pull-kubernetes-node-e2e
flake

 Cloning into 'test-infra'...
fatal: unable to access 'https://github.com/kubernetes/test-infra/': Could not resolve host: github.com 

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/area conformance

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/sig scheduling

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/test pull-kubernetes-integration
flake

dial tcp: i/o timeout writer close error:
Post \\\"https://storage.googleapis.com/upload/storage/v1/b/kubernetes-jenkins/o?alt=json\\u0026name=pr-logs%2Fpull%2F99081%2Fpull-kubernetes-integration%2F1361113427702976512%2Fstarted.json\\u0026prettyPrint=false\\u0026projection=full\\u0026uploadType=multipart\\\": oauth2: cannot fetch token:

Post \\\"https://oauth2.googleapis.com/token\\\": dial tcp: i/o timeout]\",\"file\":\"prow/cmd/initupload/main.go:45\",\"func\":\"main.main\",\"level\":\"fatal\",\"msg\":\"Failed to initialize job\",\"severity\":\"fatal\",\"time\":\"2021-02-15T00:58:40Z\"}\n") Init container place-entrypoint not ready: (state: waiting, reason: "PodInitializing", message: "")

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/test pull-kubernetes-e2e-kind
x2 flakes

  • Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2
  • Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2

Common error: tests taking to long, timed out waiting / gave up waiting

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd
flake

Kubernetes e2e suite: [sig-auth] Metadata Concealment should run a check-metadata-concealment job to completion | 15m3s

 test/e2e/auth/metadata_concealment.go:34
 Feb 15 01:19:24.319: failed to ensure job completion (metadata-concealment-614:check-metadata-concealment)
 Unexpected error:
     <*errors.errorString | 0xc000202200>: {
         s: "timed out waiting for the condition",
     }
     timed out waiting for the condition
 occurred 
test/e2e/auth/metadata_concealment.go:63

@heyste
Copy link
Member Author

heyste commented Feb 15, 2021

/test pull-kubernetes-e2e-kind
x2 flakes

  • Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2
  • Kubernetes e2e suite: [sig-storage] PersistentVolumes-local [Volume type: dir-link] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2

Common error: tests taking to long, timed out waiting / gave up waiting

@dims
Copy link
Member

dims commented Feb 15, 2021

/test pull-kubernetes-e2e-kind

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Feb 17, 2021

What is the process for making changes to conformance tests? Should we update some other file in sonobuoy so that there is no drift between what sonobuoy expects and what is available in main or release branch of k/k?

@vladimirvivien
Copy link
Member

To be clear, this test filter change should not impact Sonobuoy the project itself (as sonobuoy simply passes specified test filter directly to the e2e test binary). However, if Sonobuoy is being used in a build pipeline for conformance with a specified set of filters, this change will impact the use of Sonobouy.

@spiffxp
Copy link
Member

spiffxp commented Feb 17, 2021

/cc

@justaugustus
Copy link
Member

cc: @kubernetes/release-engineering

@justaugustus justaugustus added the area/release-eng Issues or PRs related to the Release Engineering subproject label Feb 17, 2021
@johnbelamaric
Copy link
Member

Couple questions:

  1. has this been resolved by updates to the conformance validation process? If so, why would we need to revert this?
  2. If we revert it, what problems does it cause for SIG Windows?

@johnbelamaric
Copy link
Member

@jsturtevant this is not a new test, it existed in 1.19 as well, what changed? We did fix a specific issue related to this test, where it was previously (in 1.19 and earlier) not checking if the actual ports we wired up correctly. Did that cause issues for Windows?

@jsturtevant
Copy link
Contributor

jsturtevant commented Feb 18, 2021

yes, the updates to do the checks on the ports used hostNetwork which doesn't work on windows: #96627. So we marked it linux only: #97003

I back ported it to 1.20 but maybe there was something missing or should have updated for sonobouy as well?

@jsturtevant
Copy link
Contributor

2\. If we revert it, what problems does it cause for SIG Windows?

As discussed on slack we could exclude it in our 1.20 tests. The updates to in 1.21 (#98299) don't cause issues that I have seen so far

@dims
Copy link
Member

dims commented Feb 18, 2021

@spiffxp @johnbelamaric we need this to merge in time for the next 1.20.x release. The problem is that we are getting reports from folks submitting CNCF conformance reports and the CI there is logging this as a failure. We should also pay attention on merging changes to this yaml going forward in the release branches.

@kubernetes/release-managers

@dims
Copy link
Member

dims commented Feb 18, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@johnbelamaric
Copy link
Member

After discussing with @jsturtevant, SIG windows will deal with skipping this on their own, so we can revert.

/approve

@liggitt
Copy link
Member

liggitt commented Feb 18, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@dims
Copy link
Member

dims commented Feb 18, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 18, 2021
@justaugustus
Copy link
Member

For RelEng:
/lgtm
/approve

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, heyste, johnbelamaric, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.