Clean up OWNERS for pkg/probe #99665
Conversation
k8s-ci-robot
added
release-note-none
| - tallclair | ||
| - vishh | ||
| - yujuhong | ||
| - sig-node-approvers |
There was a problem hiding this comment.
this removes @tallclair from the list. Intentional?
There was a problem hiding this comment.
Similar to 933a2ca
# see https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#LC220:~:text=sig%2Dnode%2Dreviewers
# see https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#LC220:~:text=sig%2Dnode%2Dapprovers
The comments help when I read it the first time.
There was a problem hiding this comment.
/hold
holding to make sure that removing one approver is intentional. Adding more like @mrunalp who cannot approve this PR is definitely an improvement. Feel free to un-hold
There was a problem hiding this comment.
I'll quickly ask @tallclair, I don't think he's been active in this code but he's the only effective removal.
There was a problem hiding this comment.
/hold cancel
He said he's fine being removed :)
|
/test pull-kubernetes-dependencies |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kikisdeliveryservice
moved this from Needs Reviewer
to Needs Approver
in SIG Node PR Triage
|
/approve |
k8s-ci-robot
added
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, mrunalp, tallclair, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds sig/node labels to PRs in pkg/probe.
Updates approvers to match the SIG alias.
/sig node
/cc @derekwaynecarr @dchen1107
Which issue(s) this PR fixes:
N/A, cleanup.
/priority backlog
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: