Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling runtime config on E2E node tests #99960

Merged
merged 1 commit into from Mar 9, 2021
Merged

Enabling runtime config on E2E node tests #99960

merged 1 commit into from Mar 9, 2021

Conversation

knabben
Copy link
Member

@knabben knabben commented Mar 8, 2021

What type of PR is this?

/kind feature
/area testing
/sig node

What this PR does / why we need it:

The API runtime configuration is being ignored on remote and local runner.

Which issue(s) this PR fixes:

xref #98220

Special notes for your reviewer:

For this to work on the jobs Kubetest needs to pass the runtime configuration for node job as well. This PR must arrive first.
https://github.com/kubernetes/test-infra/blob/cc576af9c1c7aa7653d15ef4bb8e3c92f83f023c/kubetest/e2e.go#L589

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

@knabben: The label(s) area/testing cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/area testing
/sig node

What this PR does / why we need it:

The API runtime configuration is being ignored on remote and local runner.

Which issue(s) this PR fixes:

xref #98220

Special notes for your reviewer:

For this to work on the jobs Kubetest needs to pass the runtime configuration for node job as well. This PR must arrive first.
https://github.com/kubernetes/test-infra/blob/cc576af9c1c7aa7653d15ef4bb8e3c92f83f023c/kubetest/e2e.go#L589

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from fejta and hwdef March 8, 2021 21:03
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 8, 2021
@ehashman
Copy link
Member

ehashman commented Mar 8, 2021

/release-note-none
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2021
@derekwaynecarr
Copy link
Member

Thanks for following up on this.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@ehashman ehashman added this to PRs - Review in progress in SIG Node CI/Test Board Mar 8, 2021
@knabben knabben mentioned this pull request Mar 8, 2021
Merged
@knabben
Copy link
Member Author

knabben commented Mar 8, 2021

/retest

@cblecker
Copy link
Member

cblecker commented Mar 8, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
SIG Node CI/Test Board automation moved this from PRs - Review in progress to PRs - Reviewer lgtm'd Mar 8, 2021
spiffxp
spiffxp approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/cc @amwat
FYI incase this changes what kubetest2 needs to support for node-e2e

@k8s-ci-robot k8s-ci-robot requested a review from amwat March 8, 2021 22:16
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, derekwaynecarr, knabben, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knabben
Copy link
Member Author

knabben commented Mar 8, 2021

@spiffxp @amwat changed kubetest on kubernetes/test-infra#21232

not sure how to see which version the job ci-kubernetes-node-kubelet-alpha is using

@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 8, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0df8c69 into kubernetes:master Mar 9, 2021
SIG Node CI/Test Board automation moved this from PRs - Reviewer lgtm'd to Done Mar 9, 2021
@aojea aojea mentioned this pull request Mar 11, 2021
Closed
@knabben knabben deleted the fix-runtime-config branch March 11, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@fejta fejta Awaiting requested review from fejta

@hwdef hwdef Awaiting requested review from hwdef

@amwat amwat Awaiting requested review from amwat

Assignees

@spiffxp spiffxp

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@knabben @k8s-ci-robot @ehashman @derekwaynecarr @cblecker @spiffxp