improve kubectl create --validate, aggregate errors and handle requir…

[feihujiang]

improve kubectl create --validate, output aggregated errors and handle required fields

[k8s-bot]

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

[feihujiang]

@satnam6502 @brendandburns @thockin Could you please review this PR?

[satnam6502]

Why not report the actual type with %T ?

[feihujiang]

@satnam6502 OK, I changed according to your advice. Could you please review this PR again?

[satnam6502]

Please can you add a risk assessment for this PR? And link to a relevant bug? Thanks.

[satnam6502]

ok to test

[satnam6502]

@k8s-bot ok to test

[k8s-bot]

GCE e2e build/test failed for commit d5fcd9f.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[satnam6502]

Retesting. If this fails again then please can someone investigate? Thanks.
@k8s-bot ok to test

[satnam6502]

@feihujiang please can you link this to an issue?

[satnam6502]

@k8s-bot ok to test

[k8s-bot]

GCE e2e build/test failed for commit d5fcd9f.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[satnam6502]

@feihujiang please can you look at why e2e fails?

[feihujiang]

#10079 @satnam6502 I post a new issues, and link this PR to it.

[feihujiang]

@satnam6502 When I opened Jenkins GCE e2e Details, it says "Access not possible". I think I have no right to open the Details now. Could you please post the Jenkins GCE e2e Details for me? Thanks!

[satnam6502]

@k8s-bot ok to test

[k8s-bot]

GCE e2e build/test passed for commit d5fcd9f.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[satnam6502]

e2e passes now. Will wait for issue to be triaged to work out milestone.

[satnam6502]

Can you copy and paste some sample output? Thanks.

[feihujiang]

@satnam6502 OK

The Invalid Pod:

   apiVersion: v1beta3
   kind: Pod
   metadata:
       labels:
           name: cassandra
       name: cassandra
   spec:
      containers:
      - args:
          - /run.sh
          resources:
            limits:
              cpu: "1"      
          name: cassandra
          ports:
          - name: cql
          - name: thrift
             containerPort: 9160
          volumeMounts:
          - name: data
            mountPath: /cassandra_data
          env:
          - name: MAX_HEAP_SIZE
            value: 512M
          - name: HEAP_NEWSIZE
            value: 100M
      volumes:
          - name: data
            emptyDir: {}

kubectl create --validate -f ./v1beta3/invalidCassandra.yaml
E0619 03:36:32.260674 14617 schema.go:153] Validation failed for: ports, [map[name:cql] map[containerPort:9160 name:thrift]]
E0619 03:36:32.260773 14617 schema.go:153] Validation failed for: containers, [map[volumeMounts:[map[mountPath:/cassandra_data name:data]] args:[/run.sh] env:[map[name:MAX_HEAP_SIZE value:512M] map[value:100M name:HEAP_NEWSIZE]] name:cassandra ports:[map[name:cql] map[containerPort:9160 name:thrift]] resources:map[limits:map[cpu:1]]]]
error validating "./v1beta3/invalidCassandra.yaml": error validating data: [ field image: is required, field containerPort: is required]

[satnam6502]

Thank you.

[satnam6502]

I will wait for the appropriate TL / meeting to determine the milestone for the associated issue before deciding what to do re: merging.