Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #99345: Updating EndpointSlice controller to wait for cache to be #100114

Merged
merged 1 commit into from Mar 12, 2021
Merged

Automated cherry pick of #99345: Updating EndpointSlice controller to wait for cache to be #100114

merged 1 commit into from Mar 12, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 11, 2021 •
edited

Cherry pick of #99345 on release-1.19.

#99345: Updating EndpointSlice controller to wait for cache to be

For details on the cherry pick process, see the cherry pick requests page.

Does this PR introduce a user-facing change?

EndpointSlice controller is now less likely to emit FailedToUpdateEndpointSlices events.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2021
@robscott
Updating EndpointSlice controller to wait for cache to be updated
95ceaca 
This updates the EndpointSlice controller to make use of the
EndpointSlice tracker to identify when expected changes are not present
in the cache yet. If this is detected, the controller will wait to sync
until all expected updates have been received. This should help avoid
race conditions that would result in duplicate EndpointSlices or failed
attempts to update stale EndpointSlices. To simplify this logic, this
also moves the EndpointSlice tracker from relying on resource versions
to generations.
@robscott
Copy link
Member Author

/sig network
/priority important-soon
/cc @bowei @swetharepakula @aojea
/assign @freehan

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot requested a review from bowei March 11, 2021 05:25
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot requested a review from aojea March 11, 2021 05:25
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: swetharepakula.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/sig network
/priority important-soon
/cc @bowei @swetharepakula @aojea
/assign @freehan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott force-pushed the automated-cherry-pick-of-#99345-release-1.19 branch from b6acd08 to 95ceaca Compare March 11, 2021 05:28
@robscott
Copy link
Member Author

/retest

@aojea
Copy link
Member

aojea commented Mar 11, 2021

/kind bug
/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@aojea
Copy link
Member

aojea commented Mar 11, 2021

/test pull-kubernetes-node-e2e

@aojea
Copy link
Member

aojea commented Mar 11, 2021

e2e failure #100124

@robscott
Copy link
Member Author

/retest

@freehan
Copy link
Contributor

freehan commented Mar 11, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 11, 2021
@cpanato
Copy link
Member

cpanato commented Mar 12, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 12, 2021
cpanato
cpanato approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, freehan, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit ef6e345 into kubernetes:release-1.19 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

@bowei bowei Awaiting requested review from bowei

@aojea aojea Awaiting requested review from aojea

Assignees

@freehan freehan

@cpanato cpanato

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @k8s-ci-robot @aojea @freehan @cpanato