Slow down creation of additional pods in density.go e2e #10020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| wg.Add(minionCount) | ||
| for i := 1; i <= minionCount; i++ { | ||
| name := additionalPodsPrefix + "-" + strconv.Itoa(i) | ||
| labels := map[string]string{ |
There was a problem hiding this comment.
This can probably be moved outside of the loop.
|
GCE e2e build/test failed for commit 21c4ec3ac71d1d71a83bd3b5944016c9b8b182e6. |
|
LGTM, short of small nit. |
piosz
added
the
lgtm
|
GCE e2e build/test failed for commit 45263c3. |
|
@k8s-bot retest this please |
|
GCE e2e build/test passed for commit 45263c3. |
|
Issue? Risk Level? Milestone? Thanks. |
|
Since this is a test I shall merger it without an associated milestone. |
satnam6502
added a commit
that referenced
this pull request
Jun 18, 2015
Slow down creation of additional pods in density.go e2e
|
Thanks @satnam6502. Issue is measuring performance in general. Risk level is low since it's only changing the test and actually the logic being changed is disabled by default as for now. |
| for i := 1; i <= minionCount; i++ { | ||
| name := additionalPodsPrefix + "-" + strconv.Itoa(i) | ||
| go createRunningPod(&wg, c, name, ns, "gcr.io/google_containers/pause:go", podLabels) | ||
| time.Sleep(200 * time.Millisecond) |
There was a problem hiding this comment.
Nit: if you're trying to rate limit to 5qps you can use util.throttle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.