Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #100638: apf: fix data race in queueset #100642

Merged
merged 1 commit into from Mar 31, 2021
Merged

Automated cherry pick of #100638: apf: fix data race in queueset #100642

merged 1 commit into from Mar 31, 2021

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Mar 29, 2021 •
edited by liggitt

Cherry pick of #100638 on release-1.21.

#100638: apf: fix test flake

Which issue(s) this PR fixes:

Fixes #98697

Fixes a regression in 1.20+ default configurations with a data race issue in the priority and fairness API server filter

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 29, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Mar 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 29, 2021
@tkashem tkashem mentioned this pull request Mar 29, 2021
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 30, 2021
@liggitt
Copy link
Member

liggitt commented Mar 30, 2021

/priority critical-urgent
/lgtm
/approve
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2021
@liggitt
Copy link
Member

liggitt commented Mar 30, 2021

@tkashem, thanks for opening this. please also open cherry-picks of #100638 to release-1.18, release-1.19, and release-1.20

@liggitt
Copy link
Member

liggitt commented Mar 30, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 30, 2021
hasheddan
hasheddan approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Waiting for PRs to other branches for CP approval.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, liggitt, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan
Copy link
Contributor

Going ahead with CP approval here as we don't have release-1.21 periodics enabled yet. 1.20/1.19/1.18 will all go in together per CP policy.

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 30, 2021
@hasheddan
Copy link
Contributor

/hold

1.21 presubmits are also not enabled.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@tkashem tkashem changed the title Automated cherry pick of #100638: apf: fix test flake Automated cherry pick of #100638: apf: fix data race in queueset Mar 30, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Mar 30, 2021

cherry-picks:
1.20: #100667
1.19: #100669
1.18: #100670

@liggitt
Copy link
Member

liggitt commented Mar 31, 2021

/test all

@liggitt
Copy link
Member

liggitt commented Mar 31, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@tkashem
Copy link
Contributor Author

tkashem commented Mar 31, 2021

/test pull-kubernetes-e2e-kind

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Mar 31, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit b3f7068 into kubernetes:release-1.21 Mar 31, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@MikeSpreitzer MikeSpreitzer Awaiting requested review from MikeSpreitzer

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@liggitt liggitt

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tkashem @liggitt @k8s-ci-robot @hasheddan