Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test with hostNetwork pods can't run in parallel #100893

Merged
merged 1 commit into from Apr 7, 2021
Merged

e2e test with hostNetwork pods can't run in parallel #100893

merged 1 commit into from Apr 7, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented Apr 7, 2021 •
edited

the tests with pods using hostNetwork need to bind pods for the
test. Since they use hostNetwork the ports are limited, hence, if
more than one run in parallel, one is going to fail because will not
be able to get the port.

NONE

Fixes: #100890,#100889

@aojea
e2e test with hostNetwork pods can't run in parallel
7c7d003 
the tests with pods using hostNetwork need to bind pods for the
test. Since they use hostNetwork the ports are limited, hence, if
more than one run in parallel, one is going to fail because will not
be able to get the port.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 7, 2021
@aojea
Copy link
Member Author

aojea commented Apr 7, 2021

/assign @thockin @spiffxp
/cc @palnabarun @thejoycekung

@aojea
Copy link
Member Author

aojea commented Apr 7, 2021

/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 7, 2021
@dims
Copy link
Member

dims commented Apr 7, 2021

/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2021
@dims
Copy link
Member

dims commented Apr 7, 2021

/hold

for @thockin 's review

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2021
@palnabarun
Copy link
Member

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 7, 2021
@palnabarun
Copy link
Member

/test pull-kubernetes-e2e-kind

@thejoycekung
Copy link
Contributor

/retest

thockin
thockin reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member Author

aojea commented Apr 7, 2021 •
edited

/hold cancel
These 2 tests failed because both tests were running in parallel, this confirm this problem
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-cos-k8sbeta-default/1379877140513689600
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-cos-k8sbeta-default/1379746155751018496

(check the inner timestamp)

I0407 11:07:32.004] [It] should function for pod-Service(hostNetwork): udp
I0407 11:07:32.004]   /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/networking.go:471
I0407 11:07:32.005] �[1mSTEP�[0m: Performing setup for networking test in namespace nettest-3814
I0407 11:07:32.005] �[1mSTEP�[0m: creating a selector
I0407 11:07:32.006] �[1mSTEP�[0m: Creating the service pods in kubernetes
I0407 11:07:32.006] Apr  7 11:02:19.235: INFO: Waiting up to 10m0s for all (but 0) nodes to be schedulable
I0407 11:07:32.006] Apr  7 11:02:21.038: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:07:32.007] Apr  7 11:02:23.146: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:07:32.007] Apr  7 11:02:25.639: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)

and 11:02 too

I0407 11:04:54.499] [It] should function for service endpoints using hostNetwork
I0407 11:04:54.499]   /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/networking.go:489
I0407 11:04:54.500] �[1mSTEP�[0m: Performing setup for networking test in namespace nettest-6471
I0407 11:04:54.500] �[1mSTEP�[0m: creating a selector
I0407 11:04:54.511] �[1mSTEP�[0m: Creating the service pods in kubernetes
I0407 11:04:54.512] Apr  7 11:02:02.729: INFO: Waiting up to 10m0s for all (but 0) nodes to be schedulable
I0407 11:04:54.512] Apr  7 11:02:03.675: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:04:54.513] Apr  7 11:02:06.020: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:04:54.513] Apr  7 11:02:08.072: INFO: The status of Pod netserver-0 is Running (Ready = false)
I0407 11:04:54.514] Apr  7 11:02:09.753: INFO: The status of Pod netserver-0 is Running (Ready = false)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 11f95dc into kubernetes:master Apr 7, 2021
@aojea
Copy link
Member Author

aojea commented Apr 7, 2021

/hold cancel
These 2 tests failed because both tests were running in parallel, this confirm this problem
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-cos-k8sbeta-default/1379877140513689600
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-cos-k8sbeta-default/1379746155751018496

I0407 11:07:32.004] [It] should function for pod-Service(hostNetwork): udp
I0407 11:07:32.004]   /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/networking.go:471
I0407 11:07:32.005] �[1mSTEP�[0m: Performing setup for networking test in namespace nettest-3814
I0407 11:07:32.005] �[1mSTEP�[0m: creating a selector
I0407 11:07:32.006] �[1mSTEP�[0m: Creating the service pods in kubernetes
I0407 11:07:32.006] Apr  7 11:02:19.235: INFO: Waiting up to 10m0s for all (but 0) nodes to be schedulable
I0407 11:07:32.006] Apr  7 11:02:21.038: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:07:32.007] Apr  7 11:02:23.146: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:07:32.007] Apr  7 11:02:25.639: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)

and 11:02 too

I0407 11:04:54.499] [It] should function for service endpoints using hostNetwork
I0407 11:04:54.499]   /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/networking.go:489
I0407 11:04:54.500] �[1mSTEP�[0m: Performing setup for networking test in namespace nettest-6471
I0407 11:04:54.500] �[1mSTEP�[0m: creating a selector
I0407 11:04:54.511] �[1mSTEP�[0m: Creating the service pods in kubernetes
I0407 11:04:54.512] Apr  7 11:02:02.729: INFO: Waiting up to 10m0s for all (but 0) nodes to be schedulable
I0407 11:04:54.512] Apr  7 11:02:03.675: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:04:54.513] Apr  7 11:02:06.020: INFO: The status of Pod netserver-0 is Pending, waiting for it to be Running (with Ready = true)
I0407 11:04:54.513] Apr  7 11:02:08.072: INFO: The status of Pod netserver-0 is Running (Ready = false)
I0407 11:04:54.514] Apr  7 11:02:09.753: INFO: The status of Pod netserver-0 is Running (Ready = false)

This was referenced Apr 7, 2021
Closed
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 19, 2021
@k8s-ci-robot
Merge pull request #100908 from aojea/automated-cherry-pick-of-#10089…
91124d5 
…3-upstream-release-1.21

Automated cherry pick of #100893: e2e test with hostNetwork pods can't run in parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@m1093782566 m1093782566 Awaiting requested review from m1093782566

@palnabarun palnabarun Awaiting requested review from palnabarun

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@dims dims

@spiffxp spiffxp

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Networking Granular Checks: Services should function for service endpoints using hostNetwork
7 participants
@aojea @dims @palnabarun @thejoycekung @k8s-ci-robot @thockin @spiffxp