Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: use kubelet 10248 as health check port instead of 10255 #101139

Closed
wants to merge 1 commit into from
Closed

e2e: use kubelet 10248 as health check port instead of 10255 #101139

wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Apr 15, 2021 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

healthCheckURL=http://127.0.0.1:10248/healthz
instead of
healthCheckURL=http://127.0.0.1:10255/healthz

Which issue(s) this PR fixes:

xrefs #12968: deprecate Kubelet Read-only port (in the future)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2021
@pacoxu
use kubelet 10248 as health check port instead of 10255
396cb37 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
To complete the pull request process, please assign connordoyle after the PR has been reviewed.
You can assign the PR to them by writing /assign @connordoyle in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu pacoxu mentioned this pull request Apr 15, 2021
Closed
5 tasks
@ehashman ehashman added this to Triage in SIG Node PR Triage Apr 15, 2021
@ehashman ehashman added this to Triage in SIG Node CI/Test Board Apr 15, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Apr 19, 2021

/cc tallclair troy0820

@SergeyKanzhelev
Copy link
Member

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 21, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Apr 21, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Reviewer in SIG Node PR Triage Apr 21, 2021
@pacoxu pacoxu mentioned this pull request Apr 26, 2021
Closed
@pacoxu
Copy link
Member Author

pacoxu commented May 20, 2021

#100335 test failed which is related to the 10255 port.

/assign @ConnorDoyle @mrunalp
Would you take a look?

@pacoxu pacoxu marked this pull request as draft May 24, 2021 02:45
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2021
@pacoxu pacoxu closed this May 24, 2021
@pacoxu pacoxu mentioned this pull request Jun 23, 2021
Open
@pacoxu pacoxu deleted the test-10255 branch June 23, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tallclair tallclair Awaiting requested review from tallclair

@troy0820 troy0820 Awaiting requested review from troy0820

Assignees

@mrunalp mrunalp

@ConnorDoyle ConnorDoyle

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
PRs - Needs Reviewer
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacoxu @k8s-ci-robot @SergeyKanzhelev @mrunalp @ConnorDoyle