GKE upgrade tests #10133
Merged
GKE upgrade tests #10133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const ( | ||
| // version applies to upgrades; kube-push always pushes local binaries. | ||
| version = "latest_ci" | ||
| versionURL = "https://storage.googleapis.com/kubernetes-release/%s/%s.txt" |
There was a problem hiding this comment.
Done. (My Go names are getting too short...) (Not yet pushed.)
|
Handful of comments. Overall looks good. |
|
Thanks—all comments addressed. Should have fixed Shippable too. PTAL. |
|
Well, shippable seems permanently dead and won't show the logs. Hmm. Ugh. |
|
LGTM once jenkins builder passes. |
roberthbailey
added
the
lgtm
|
GCE e2e build/test passed for commit 434f968. |
|
Weekend merging for increased GKE test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE node (#7914) and master (#8081) upgrade tests. Adds support for running
cluster_upgrade.gowith the GKE provider.Final TODOs after this to close those issues are:
After that, our next TODOs are:
+cc @mikedanese @zmerlynn @quinton-hoole @ixdy