Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [DO NOT REVIEW] Test P&F watch initialization #101785

Closed
wants to merge 2 commits into from
Closed

[WIP] [DO NOT REVIEW] Test P&F watch initialization #101785

wants to merge 2 commits into from

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented May 7, 2021 

NONE

@wojtek-t wojtek-t self-assigned this May 7, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2021
@wojtek-t
Copy link
Member Author

wojtek-t commented May 7, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 7, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch 2 times, most recently from 4b982e6 to d63325b Compare May 7, 2021 13:17
@wojtek-t wojtek-t mentioned this pull request May 10, 2021
Merged
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch from d63325b to 67f043b Compare May 14, 2021 07:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2021
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch 5 times, most recently from 1b7c2ca to 0eb3196 Compare May 14, 2021 11:12
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch from 0eb3196 to 299f63e Compare May 14, 2021 13:11
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch from 299f63e to 76a1b35 Compare May 17, 2021 13:55
@wojtek-t wojtek-t force-pushed the prototype_watch_initialization branch from 4773f56 to 5f19207 Compare May 20, 2021 10:00
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-verify 5f19207 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wojtek-t
Copy link
Member Author

Closing in favor of #102171

@wojtek-t wojtek-t closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wojtek-t @k8s-ci-robot